Emphasize txt to json conversion while creating pull_secret.json #72
Conversation
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @tshefi. Thanks for your PR. I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Wasted a few hours trying to figureout why kcli env script hung after creating the VMs, downloading openshift client had failed due to my pull_secret.json content txt vs json, duh moment. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
| @@ -32,7 +32,7 @@ Go to https://console-openshift-console.apps.ci.l2s4.p1.openshiftapps.com/, clic | |||
| right, copy the login command, extract the token from the command and use it to set `CI_TOKEN` in `config_$USER.sh`. | |||
|
|
|||
| #### Get pull secret | |||
| Save the secret obtained from [cloud.openshift.com](https://cloud.redhat.com/openshift/install/pull-secret) to `pull_secret.json`. | |||
| Convert the secret obtained from [cloud.openshift.com](https://cloud.redhat.com/openshift/install/pull-secret), originally in text format, into JSON format and save it as `pull_secret,json`. | |||
There was a problem hiding this comment.
Isn't the downloaded file already in JSON format? Did you need to do any conversion other than renaming from pull-secret.txt to pull_secret.json? If only renamed was needed then I think it would be good to explicitly say that here.
There was a problem hiding this comment.
Nope apparently it's txt, if you use the other option clicking "copy" it will copy the data (txt) into clipboard, I too didn't give it much thought, created an empty pull_secret.json file and pasted clipboard data(txt). Only when things failed again and again I started to investigate/debug, figured out the missing conversion. Thats why I figured I should mention this issue.
There was a problem hiding this comment.
Hey @tshefi, what do you mean by 'conversion to JSON'? I.e. which operation exactly did you have to make? I've just tried to use the 'Copy pull secret' button, and the result seems the same as the downloaded file:/
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhernand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
No description provided.