Add defaults for deployment manager backend URL and token #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irinamihai
reviewed
Apr 2, 2024
irinamihai
reviewed
Apr 2, 2024
irinamihai
reviewed
Apr 2, 2024
Currently the backend URL and token don't have defaults. That means that the user has to explicitly set them in the custom resource that represents the O2 IMS deployment. That is reasonable for the URL, but not for the token, because it is the token of a service account that is created by the operator. That means that the user would have to create the service account in advance, wait for the token to be created and then read it and update the custom resource. That isn't practical. To avoid that this patch changes the operator so that the token is the default URL of the Kubernetes API server and the token is taken from the `/run/secrets/kubernetes.io/serviceaccount/token` file. Signed-off-by: Juan Hernandez <[email protected]> Co-authored-by: Irina Mihai <[email protected]>
jhernand
force-pushed
the
add_defaults_for_backend_url_and_token
branch
from
5749dbe to
43df8a4
Compare
irinamihai
reviewed
Apr 3, 2024
| @@ -9,5 +9,5 @@ generatorOptions: | |||
|
|
|||
| images: | |||
| - name: controller | |||
| newName: quay.io/imihai/oran-o2ims-operator | |||
| newTag: 4.16.0 | |||
| newName: quay.io/jhernand/o2ims-operator | |||
There was a problem hiding this comment.
Just a note that we will have to update these to the o2ims quay repo.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irinamihai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the backend URL and token don't have defaults. That means that the user has to explicitly set them in the custom resource that represents the O2 IMS deployment. That is reasonable for the URL, but not for the token, because it is the token of a service account that is created by the operator. That means that the user would have to create the service account in advance, wait for the token to be created and then read it and update the custom resource. That isn't practical. To avoid that this patch changes the operator so that the token is the default URL of the Kubernetes API server and the token is taken from the
/run/secrets/kubernetes.io/serviceaccount/tokenfile.