Support creation of non namespaced objects in createk8scr #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Note that this pull request also includes the code in #85. That should be merged before this, and then this should be rebased. |
Kubernetes forbids the creation of object in one namespace with owners in another namespace, or the creation of non-namespaced objects with namespaced owners. But the `CreateK8sCR` function doesn't support. We will need that in order to create cluster roles and cluster role bindings. This patch changes the function so that it will not try to set an owner if the namespace of the object and the namespace of the owner are different. Signed-off-by: Juan Hernandez <[email protected]>
jhernand
force-pushed
the
support_creation_of_non_namespaced_objects_in_createk8scr
branch
from
508821b to
a95618c
Compare
jhernand
deleted the
support_creation_of_non_namespaced_objects_in_createk8scr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes forbids the creation of object in one namespace with owners in another namespace, or the creation of non-namespaced objects with namespaced owners. But the
CreateK8sCRfunction doesn't support. We will need that in order to create cluster roles and cluster role bindings. This patch changes the function so that it will not try to set an owner if the namespace of the object and the namespace of the owner are different.