Remove oldObject parameter from CreateK8sCR
#87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irinamihai
reviewed
Apr 11, 2024
internal/controllers/utils/utils.go
Outdated
| @@ -31,7 +31,11 @@ func CreateK8sCR(ctx context.Context, c client.Client, | |||
| return err | |||
| } | |||
|
|
|||
| // Check if the CR already exists. | |||
| // Create an empty object of the same type of the new object. We will use it to store the | |||
| // fetch the current state. | |||
There was a problem hiding this comment.
Suggested change
| // fetch the current state. | |
| // fetch of the current state. |
There was a problem hiding this comment.
Thanks @irinamihai, I will fix this.
Currently the `CreateK8sCR` function receives an `oldObject` parameter that is needed because the function doesn't know how to create an empty object of the same type of the object that is going to be created. But that can be solved using reflection, something like this: ```go // Create an empty object of the same type of the new object. We will use it to store the // fetch the current state. objectType := reflect.TypeOf(newObject).Elem() oldObject := reflect.New(objectType).Interface().(client.Object) ``` This patch does that and removes the `oldObject` parameter, which simplifies the code that calls the `CreateK8sCR` function. Signed-off-by: Juan Hernandez <[email protected]>
jhernand
force-pushed
the
remove_old_object_parameter_from_createk8scr
branch
from
5f2722c to
b3a0703
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irinamihai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
CreateK8sCRfunction receives anoldObjectparameter that is needed because the function doesn't know how to create an empty object of the same type of the object that is going to be created. But that can be solved using reflection, something like this:This patch does that and removes the
oldObjectparameter, which simplifies the code that calls theCreateK8sCRfunction.