Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconciler task #89

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

jhernand
Copy link
Collaborator

This patch adds a new reconcilerTask that contains the logic and data needed to perform the reconciliation process. It contains, for example, the state of the object being reconciled. This reduces the number of parameters that need to be passed to methods, as some of them are available as fields of the receiver.

This patch adds a new `reconcilerTask` that contains the logic and data
needed to perform the reconciliation process. It contains, for example,
the state of the object being reconciled. This reduces the number of
parameters that need to be passed to methods, as some of them are
available as fields of the receiver.

Signed-off-by: Juan Hernandez <[email protected]>
@openshift-ci openshift-ci bot requested review from danielerez and irinamihai April 12, 2024 11:21
Copy link

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jhernand. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhernand jhernand merged commit d5e5802 into openshift-kni:main Apr 12, 2024
7 of 8 checks passed
@jhernand jhernand deleted the add_reconciler_task branch April 12, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant