Make image configurable #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the container image used by the servers is hardcoded in the Go source code. This complicates development because when the operator is deployed it isn't possible to use a custom image. To simplify that this patch adds a new `--image` command line flag to the `start controller-manager` command. The default will be `quay.io/openshift-kni/oran-o2ims:latest`, but it will be possible to change it in the the development environment, in two different ways: 1. Changing the `IMG` make variable, for example: ``` $ make IMG=quay.io/myuser/myimage:123 build deploy ``` 2. Using the `spec.image` field of the custom resource. The patch also changes The kustomization files used to generate tha operator manifests so that the selected image is automatically passed to the `--image` command line flag. Signed-off-by: Juan Hernandez <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the container image used by the servers is hardcoded in the Go source code. This complicates development because when the operator is deployed it isn't possible to use a custom image. To simplify that this patch adds a new
--imagecommand line flag to thestart controller-managercommand. The default will bequay.io/openshift-kni/oran-o2ims:latest, but it will be possible to change it in the the development environment, in two different ways:IMGmake variable, for example:spec.imagefield of the custom resource.The patch also changes The kustomization files used to generate tha operator manifests so that the selected image is automatically passed to the
--imagecommand line flag.