Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for paging #94

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

jhernand
Copy link
Collaborator

This patch adds support for the nextpage_opaque_marker parameter as defined in section 5.4 of ETSI GS NFV-SOL 013. A new NextPageMarker field is added to the ListRequest and ListResponse. The adapter takes care of encoding and encrypting it, and the handler only needs to read it from the request or write it to the response. The type of the field is []byte and the handler that uses it is responsible for encoding and decoding it if needed.

Related: https://www.etsi.org/deliver/etsi_gs/NFV-SOL/001_099/013/03.05.01_60/gs_NFV-SOL013v030501p.pdf

@openshift-ci openshift-ci bot requested review from danielerez and irinamihai April 25, 2024 10:50
Copy link

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jhernand. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhernand jhernand force-pushed the add_paging_support branch 2 times, most recently from 0ae88fd to 51ec145 Compare April 25, 2024 10:57
This patch adds support for the `nextpage_opaque_marker` parameter as
defined in section 5.4 of ETSI GS NFV-SOL 013. A new `NextPageMarker`
field is added to the `ListRequest` and `ListResponse`. The adapter
takes care of encoding and encrypting it, and the handler only needs
to read it from the request or write it to the response. The type of
the field is `[]byte` and the handler that uses it is responsible for
encoding and decoding it if needed.

Related: https://www.etsi.org/deliver/etsi_gs/NFV-SOL/001_099/013/03.05.01_60/gs_NFV-SOL013v030501p.pdf
Signed-off-by: Juan Hernandez <[email protected]>
@jhernand jhernand force-pushed the add_paging_support branch from 51ec145 to 1b4c00a Compare April 25, 2024 10:59
@jhernand jhernand merged commit 5e0b4d7 into openshift-kni:main Apr 25, 2024
7 of 8 checks passed
@jhernand jhernand deleted the add_paging_support branch April 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant