Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription server use ConfigMap as persistent storage as well as IPC #96

Merged
merged 1 commit into from
May 14, 2024
Merged

Subscription server use ConfigMap as persistent storage as well as IPC #96

merged 1 commit into from
May 14, 2024

Conversation

Jennifer-chen-rh
Copy link
Collaborator

This is WIP version for alarm subscription server using configmap for now.

@openshift-ci openshift-ci bot requested review from irinamihai and jhernand April 26, 2024 15:19
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign irinamihai for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jennifer-chen-rh
Copy link
Collaborator Author

@jhernand This is WIP version. I will work/double check the corresponding go-test codes. Also need the multiple configmap instances to make it scale better.

For the go route loop, I currently use sleeping. do we have other approach not using sleeping? Also when we support multiple configmap instances, what's general practice here: use single thread to watch all, or each thread watch single instance of configmap?

jhernand
jhernand reviewed Apr 26, 2024
View reviewed changes
internal/cmd/server/start_alarm_subscription_server.go Outdated Show resolved Hide resolved
internal/k8s/client.go Show resolved Hide resolved
internal/service/alarm_subscription_handler.go Outdated Show resolved Hide resolved
internal/service/alarm_subscription_handler.go Outdated Show resolved Hide resolved
internal/service/alarm_subscription_handler.go Outdated Show resolved Hide resolved
internal/service/alarm_subscription_handler.go Outdated Show resolved Hide resolved
internal/service/alarm_subscription_handler.go Outdated Show resolved Hide resolved
internal/service/alarm_subscription_handler.go Outdated Show resolved Hide resolved
internal/service/handlers.go Outdated Show resolved Hide resolved
internal/service/handlers.go Outdated Show resolved Hide resolved
@Jennifer-chen-rh Jennifer-chen-rh force-pushed the jenchen/main_alert_subscription_configmap branch 3 times, most recently from 0c2b2a2 to 03ec63c Compare May 8, 2024 20:47
@Jennifer-chen-rh Jennifer-chen-rh changed the title draft: Subscription server use ConfigMap as IPC (2 subscription servers working version) Subscription server use ConfigMap as persistent storage as well as IPC May 8, 2024
@Jennifer-chen-rh Jennifer-chen-rh force-pushed the jenchen/main_alert_subscription_configmap branch from 03ec63c to 5bef1d6 Compare May 9, 2024 15:44
@Jennifer-chen-rh
1. Generic support to use k8s configmap as a persist storage.
61c3a14 
2. Alarmubscription servers use ConfigMap as subscriptions persist storage
as well as ipc synch

 Signed-off-by: Jennifer Chen <[email protected]>
@Jennifer-chen-rh Jennifer-chen-rh force-pushed the jenchen/main_alert_subscription_configmap branch from 5bef1d6 to 61c3a14 Compare May 10, 2024 19:07
@jhernand jhernand merged commit 9abe849 into openshift-kni:main May 14, 2024
7 of 8 checks passed
@Jennifer-chen-rh Jennifer-chen-rh deleted the jenchen/main_alert_subscription_configmap branch July 19, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhernand jhernand jhernand left review comments

@irinamihai irinamihai Awaiting requested review from irinamihai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jennifer-chen-rh @jhernand