WIP: Add plugin API #99
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
api/v1alpha1/node_order_types.go
Outdated
|
|
||
| // BMC contains the details needed to connect to the baseboard management controller of a node. | ||
| type BMC struct { | ||
| URL string `json:"url"` |
There was a problem hiding this comment.
Just a reminder, we probably want a reference to the creds secret here.
E.g.
CredentialsSecretName string
There was a problem hiding this comment.
Yes, I added that in the latest version of the patch.
| // FirmwareSettings contains the firmware settings for the nodes that use this profile. | ||
| // | ||
| // +kubebuilder:validation:Optional | ||
| FirmwareSettings map[string]string `json:"firmwareSettings,omitempty"` |
There was a problem hiding this comment.
IIRC, there was a requirement to support separate extensions maps for FirmwareSettings and FirmwareVersions (?)
I.e. we can consider having these as structs instead of maps.
There was a problem hiding this comment.
Actually I think I will remove these fields in favor of the extensions. Vendors can there add whatever they need. For example:
extensions:
- oran.acme.com/firmwareSettings: |
{
"CStates": "C6",
"VirtualizationEnabled": "true"
}
- oran.acme.com/firmwareVersions: |
{
"UEFI": "1.3",
"NIC": "2.7"
}In the future if we see that different vendors use the same data structures we can re-add these fields.
There was a problem hiding this comment.
Nice, sounds like a good idea. Just probably worth to document that example for the keys then.
api/v1alpha1/condition_types.go
Outdated
| const ( | ||
| // OrderFulfilledCondition is the condition that indicates that an order has been | ||
| // completely and successfully completed. | ||
| OrderFulfilledCondition = "Fullfilled" |
There was a problem hiding this comment.
Thanks Irinal, will do.
| // Location is the geographical location of the requested deployment manager. | ||
| // | ||
| // +kubebuilder:validation:Required | ||
| Location string `json:"profile"` |
There was a problem hiding this comment.
For consistency, shouldn't the golang variable and the json key have the same name, location / profile in this case? Or is the difference here intended?
There was a problem hiding this comment.
Yes, this is a plain mistake, I will fix the JSON key.
| // deployment manager. | ||
| // | ||
| // +kubebuilder:validation:Required | ||
| Template string `json:"template,omitempty"` |
There was a problem hiding this comment.
I don't think we need omitempty if the field is Required.
There was a problem hiding this comment.
OK, will remove it.
| metav1.TypeMeta `json:",inline"` | ||
| metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
|
||
| // NodeProfiles is a collection of named node profiles that will be ued in the template. |
| Extensions map[string]string `json:"extensions,omitempty"` | ||
| } | ||
|
|
||
| // DeploymentManagerTemplateNodeProfile associates a name with a set of node node settings. |
|
|
||
| // DeploymentManager is the schema a deployment manager. | ||
| // | ||
| // +kubebuilder:resource:shortName=dm |
There was a problem hiding this comment.
Maybe dmgr would be a bit more descriptive?
There was a problem hiding this comment.
It is more descriptive, but it would make other short names longer and harder to type, for example dmgrtemplate instead of dmtemplate. I will keep this for now, unless you have a strong objection.
api/v1alpha1/node_order_types.go
Outdated
|
|
||
| // BMCDetails contains the details needed to connect to the baseboard management controller of | ||
| // a node. | ||
| type BMCDetails struct { |
There was a problem hiding this comment.
I don't see this structure used anywhere. Is it for future use?
There was a problem hiding this comment.
It is used in the next version of the patch.
jhernand
force-pushed
the
add_plugin_api
branch
2 times, most recently
from
4151eaa to
46e91ef
Compare
This patch adds the definition of the Kubernetes custom resource definitions that will be used by the O2 IMS implementation to interact with the hardware manager. Signed-off-by: Juan Hernandez <[email protected]>
jhernand
force-pushed
the
add_plugin_api
branch
2 times, most recently
from
e99c09b to
5ea8ef0
Compare
This patch adds the definition of the Kubernetes custom resource definitions that will be used by the O2 IMS implementation to interact with the hardware manager.