Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functests: utils: add and use event reporting #765

Merged

Conversation

ffromani
Copy link
Member

Add a function to fetch the events associated to a object,
and use it into the 4_latency suite to troubleshoot the
pod startup issues.

Also add a trivial tester program.

Signed-off-by: Francesco Romani [email protected]

@openshift-ci openshift-ci bot requested review from fedepaol and SchSeba October 19, 2021 07:29
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
@coveralls
Copy link

coveralls commented Oct 19, 2021

Pull Request Test Coverage Report for Build 2010

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.352%

Totals Coverage Status
Change from base Build 2007: 0.0%
Covered Lines: 1570
Relevant Lines: 2559

💛 - Coveralls

Copy link
Contributor

@cynepco3hahue cynepco3hahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be useful to dump events for all failure tests, it will require introducing some additional reporter, similar to https://github.com/kubevirt/kubevirt/blob/5d06fbd6f72cd6ee60e8c4c57d014f7ee0d82acb/tests/reporter/outputenricher.go#L64

tools/getevents/getevents.go Outdated Show resolved Hide resolved
Add a function to fetch the events associated to a object,
and use it into the 4_latency suite to troubleshoot the
pod startup issues.

Also add a trivial tester program.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani
Copy link
Member Author

Can be useful to dump events for all failure tests, it will require introducing some additional reporter, similar to https://github.com/kubevirt/kubevirt/blob/5d06fbd6f72cd6ee60e8c4c57d014f7ee0d82acb/tests/reporter/outputenricher.go#L64

nice! we should totally explore this option in a followup PR. Maybe let's file an issue to track this?

@cynepco3hahue
Copy link
Contributor

nice! we should totally explore this option in a followup PR. Maybe let's file an issue to track this?

Works for me

@cynepco3hahue
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021
@ffromani
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 5856115 into openshift-kni:master Oct 20, 2021
@ffromani
Copy link
Member Author

nice! we should totally explore this option in a followup PR. Maybe let's file an issue to track this?

Works for me

#767

@ffromani ffromani deleted the event-reporting branch October 27, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants