introduce the logtracr #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ffromani
force-pushed
the
kni-logger
branch
5 times, most recently
from
151212a to
184cc4a
Compare
ffromani
force-pushed
the
kni-logger
branch
2 times, most recently
from
eee13a0 to
cd4890e
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ffromani
force-pushed
the
kni-logger
branch
5 times, most recently
from
3be3e31 to
54e766a
Compare
Introduce the logtracr logger. The logtracr logger builds upon and augments the existing klog (+logr) infrastructure to provide per-object (vs per-component) log. This logger implement a simplistic, in-process lookalike of a tracing logger, whose concepts (spans and traces) kinda remind of opentelemetry's concepts. In a nutshell, the logger aims to make it possible/easier to correlate all the logs pertaining to a container during a scheduling cycle For full design details please check the upcoming `pkg-kni/logtracr/DESIGN.md`. Signed-off-by: Francesco Romani <[email protected]>
add design/arch document how logtracr works and the implementation choices. Signed-off-by: Francesco Romani <[email protected]>
|
/retest |
|
bad approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the logtracr logger. The logtracr logger builds upon and augments the existing klog (+logr)
infrastructure to provide per-object (vs per-component) log.
This logger implement a simplistic, in-process lookalike of a tracing logger, whose concepts (spans and traces) kinda remind of opentelemetry's concepts.
In a nutshell, the logger aims to make it possible/easier to correlate all the logs pertaining to a container during a scheduling cycle
For full design details please check
pkg-kni/logtracr/DESIGN.md.