[KNI] resync 20240624 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add unit-test.sh args customizable
A upcoming change in the overreserve cache wants to consume nodeconfig utilities, so in order to enable both packages to consume this code, we move it in its own package. Trivial code movement and only necessary interface changes (renames/public <-> private symbols). Signed-off-by: Francesco Romani <[email protected]>
create and require watchable client. The watchable client is fully supported by the controller-runtime client and it's a superset of the regular client, so this change is fully backward compatible. Signed-off-by: Francesco Romani <[email protected]>
In the NodeResourceTopologyMatch plugin we only need to consume resources, never to change them. So let's use a Reader instead of a full client. Signed-off-by: Francesco Romani <[email protected]>
One of the key assumptions we took when designing the NodeResourceTopology (NRT) plugin is that the kubelet configuration of the worker node changes *very* rarely, if at all, during the cluster lifetime. As rule of thumb, it was expected to change with a frequency of like once every quarter (3 months) or so, and likely less often. So the event of changing during a scheduling cycle was deemed extremely low. However, we fail to notice kubelet configuration changes (the bits we care reported by NRT data) and we update them incidentally when resyncing the cache. These updates are expected to be rare, but still failing to noticing them is a much worse issue: with out of date configuration information, the scheduler plugin will take wrong decisions until restarted. Up until now, the mitigation was to restart the scheduler once kubelet config changes; this works, but it is unpractical and requires more orchestration. We add the option to resync the NRT data if the attribute change (and nothing else did) to overcome this limitation. In the current framework, because of how controller-runtime/client works, this will require a new connection to the apiserver to watch the changes and react to them, adding the node to the set of the one being resynced in the next resync iteration. Even considering HA scheduler scenarios, this will cause a very limited amount of new connections, and should not cause any scalability concern. Nevertheless, we make the feature opt-in. Signed-off-by: Francesco Romani <[email protected]>
Switch the default and prefer correctness over backward compatibility, because the previous behavior was buggy (see: kubernetes-sigs#621) Signed-off-by: Francesco Romani <[email protected]>
Convert update-codegen.sh to new codegen
…-updates [noderesourcetopology] update NRT when attributes change
Signed-off-by: Francesco Romani <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resync upstream 20240624