Skip to content

Conversation

@mmazur
Copy link

@mmazur mmazur commented Oct 14, 2025

Currently it says "first tested". This is incorrect for the prod environment, since it's quite possible that a particular release was first tested in int, but the code doesn't actually check that, it only checks for whether testing in ENV happened in ENV-1.

Which is why I've corrected the wording of the message slightly to be less ambiguous.

Currently it says "first tested". This is incorrect for the prod
environment, since it's quite possible that a particular release was
*first* tested in int, but the code doesn't actually check that, it only
checks for whether testing in ENV happened in ENV-1.

Which is why I've corrected the wording of the message slightly to be less
ambiguous.
@openshift-ci openshift-ci bot requested a review from bennerv October 14, 2025 12:47
@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmazur
Once this PR has been reviewed and has the lgtm label, please assign jharrington22 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from deads2k October 14, 2025 12:47
@mmazur
Copy link
Author

mmazur commented Oct 14, 2025

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2025

@mmazur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 0db3f26 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant