[rhaiis] Add custom model and workload stubs for dashboard overrides - #179
[rhaiis] Add custom model and workload stubs for dashboard overrides#179ssaketh-ch wants to merge 2 commits into
Conversation
Adds custom entries in models.yaml and workloads.yaml so the dashboard UI can override hf_model_id and GuideLLM profile fields at runtime. Also removes rampup from profile1 through profile4 in workloads.yaml.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test fournos rhaiis nvidia benchmark hera ci-quick |
🔴 Execution of
|
🔴 Submission of
|
| profile7: | ||
| tests.rhaiis.workload_key: profile7 | ||
|
|
||
| custom: |
There was a problem hiding this comment.
these presets are not required.
|
@ssaketh-ch could you re trigger the ci test, with recommendation from Kevin. there was a transient pvc error on Hera which should be fixed now. |
Adds agentic failure review capability based on feedback. Also drops custom presets since they're not required.
|
/test fournos rhaiis nvidia benchmark hera custom |
🔴 Submission of
|
|
| metrics: {} | ||
|
|
||
| agentic: | ||
| enabled: true |
There was a problem hiding this comment.
that's the agentic configure & failure review I presented yesterday
|
/test fournos rhaiis nvidia benchmark hera ci-quick |
|
/test fournos rhaiis nvidia benchmark hera ci-quick |
🟢 Execution of
|
🟢 Submission of
|
The first trigger failed due to a parsing issue. The second time succeeded so it doesn't seems to be a command error. Need to be careful when triggering via comments. |
🔴 Submission of
|
|
@ssaketh-ch: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
🟢 Execution of
|
Summary
custommodel and workload entries so the dashboard can sethf_model_id,vllm_args, and GuideLLM profile fields at job timethrough
configOverrides.rampupfrom profile1 through profile4 in workloads.yaml.Motivation
Quick fix based on feed back to override the yaml directly from the UI.