-
Notifications
You must be signed in to change notification settings - Fork 14
feat(rhaiis): add native HTTP profiler backend [Under test] #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
naveenmiriyaluredhat
wants to merge
1
commit into
openshift-psap:main
Choose a base branch
from
naveenmiriyaluredhat:feat/rhaiis-native-profiler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,3 +6,67 @@ benchmark: | |
| rhaiis.profiler.enabled: true | ||
| caliper.postprocess.csv_dashboard.enabled: true | ||
| rhaiis.agent_analysis.enabled: false | ||
|
|
||
| # Cluster webhook + /tmp/profiler_gate (vLLM only). This is also the | ||
| # default when rhaiis.profiler.backend is unset. | ||
| profiler-webhook: | ||
| rhaiis.profiler.enabled: true | ||
| rhaiis.profiler.backend: webhook | ||
|
|
||
| # vLLM 0.13+ HTTP /start_profile + /stop_profile (torch Chrome traces). | ||
| # Example: | ||
| # --preset llama-8b --preset profile1 --preset profiler-native | ||
| profiler-native: | ||
| rhaiis.profiler.enabled: true | ||
| rhaiis.profiler.backend: native | ||
| rhaiis.profiler.kind: torch | ||
|
|
||
| # Short native capture: one concurrent stream, 60s GuideLLM window. | ||
| # Prefer this over profiler-native when you only need a trace, not a 200s soak. | ||
| profiler-native-short: | ||
| rhaiis.profiler.enabled: true | ||
| rhaiis.profiler.backend: native | ||
| rhaiis.profiler.kind: torch | ||
| rhaiis.profiler.rates: [1] | ||
| rhaiis.profiler.max_seconds: 60 | ||
|
|
||
| # Skip 50 engine iterations, then record 10. GuideLLM still runs for max_seconds; | ||
| # the engine stops recording after max_iterations. | ||
| profiler-native-window: | ||
| rhaiis.profiler.enabled: true | ||
| rhaiis.profiler.backend: native | ||
| rhaiis.profiler.kind: torch | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. here you should use the that's a simple mechanism that just inserts the |
||
| rhaiis.profiler.rates: [1] | ||
| rhaiis.profiler.max_seconds: 120 | ||
| rhaiis.profiler.native.delay_iterations: 50 | ||
| rhaiis.profiler.native.max_iterations: 10 | ||
| rhaiis.profiler.native.ignore_frontend: true | ||
|
|
||
| # Nsight Systems via CUDA profiler API. The serving image must contain `nsys`. | ||
| profiler-native-cuda: | ||
| rhaiis.profiler.enabled: true | ||
| rhaiis.profiler.backend: native | ||
| rhaiis.profiler.kind: cuda | ||
| rhaiis.profiler.native.nsys_wrap: true | ||
| rhaiis.profiler.rates: [1] | ||
| rhaiis.profiler.max_seconds: 60 | ||
|
|
||
| # Triton Proton (eager mode). Open chrome_trace in Perfetto; hatchet needs proton-viewer. | ||
| profiler-native-proton: | ||
| rhaiis.profiler.enabled: true | ||
| rhaiis.profiler.backend: native | ||
| rhaiis.profiler.kind: proton | ||
| rhaiis.profiler.native.proton_output_format: chrome_trace | ||
| rhaiis.profiler.rates: [1] | ||
| rhaiis.profiler.max_seconds: 60 | ||
|
|
||
| # SGLang native profiler (SGLANG_TORCH_PROFILER_DIR + /start_profile). | ||
| # num_steps auto-stops the engine profiler; /stop_profile is still attempted. | ||
| profiler-native-sglang: | ||
| rhaiis.engine: sglang | ||
| rhaiis.profiler.enabled: true | ||
| rhaiis.profiler.backend: native | ||
| rhaiis.profiler.rates: [1] | ||
| rhaiis.profiler.max_seconds: 60 | ||
| rhaiis.profiler.native.num_steps: 10 | ||
| rhaiis.profiler.native.start_step: 5 | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try to keep all the constants in the config. That's not an absolute rule, more a guideline.
If you have:
then maybe another way you (or someone else) will be happy to just have to define a preset to change