Document Tekton timeout configuration - #107
Conversation
Add a Timeouts subsection to Section 8 (Tekton Pipelines and Tasks) explaining the PipelineRun-level timeouts set by Fournos and the cluster-wide default-timeout-minutes ConfigMap that can override individual TaskRun timeouts. Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe design document adds a “Timeouts” section covering Fournos PipelineRun deadlines, Tekton TaskRun defaults, and an ChangesTimeout documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Fournos_Design_Document.md`:
- Around line 331-340: The cluster-wide Tekton timeout guidance should
distinguish older behavior from current precedence. Update the section around
“Cluster-wide Tekton default” to state that
config-defaults.default-timeout-minutes is only relevant for clusters with older
Tekton behavior; on current Tekton versions, the PipelineRun timeouts.tasks
value takes precedence and covers generated TaskRuns without explicit timeouts.
Retain the oc patch command only as an older-cluster workaround and align its
explanation with the documented 24h task timeout.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e39e613c-74b7-4b8c-b440-0e1047ac1939
📒 Files selected for processing (1)
Fournos_Design_Document.md
Co-authored-by: Cursor <cursoragent@cursor.com>
Add a Timeouts subsection to Section 8 (Tekton Pipelines and Tasks) explaining the PipelineRun-level timeouts set by Fournos and the cluster-wide default-timeout-minutes ConfigMap that can override individual TaskRun timeouts.
Summary by CodeRabbit
default-timeout-minutesbehavior for TaskRuns without explicit timeouts.oc patchcommand to adjust the default timeout to avoid early TaskRun termination.