Skip to content

Document Tekton timeout configuration - #107

Merged
kpouget merged 2 commits into
openshift-psap:mainfrom
Harshith-umesh:docs/tekton-timeout-config
Jul 30, 2026
Merged

Document Tekton timeout configuration#107
kpouget merged 2 commits into
openshift-psap:mainfrom
Harshith-umesh:docs/tekton-timeout-config

Conversation

@Harshith-umesh

@Harshith-umesh Harshith-umesh commented Jul 23, 2026

Copy link
Copy Markdown
Member

Add a Timeouts subsection to Section 8 (Tekton Pipelines and Tasks) explaining the PipelineRun-level timeouts set by Fournos and the cluster-wide default-timeout-minutes ConfigMap that can override individual TaskRun timeouts.

Summary by CodeRabbit

  • Documentation
    • Added a new “Timeouts” section covering how Fournos sets PipelineRun, task, and finally-task timeout behavior.
    • Documented Tekton’s cluster-wide default-timeout-minutes behavior for TaskRuns without explicit timeouts.
    • Included an example oc patch command to adjust the default timeout to avoid early TaskRun termination.

Add a Timeouts subsection to Section 8 (Tekton Pipelines and Tasks)
explaining the PipelineRun-level timeouts set by Fournos and the
cluster-wide default-timeout-minutes ConfigMap that can override
individual TaskRun timeouts.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sjmonson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b7f2ec88-9c3e-40fe-b7f8-0e9286f26336

📥 Commits

Reviewing files that changed from the base of the PR and between f93fcb7 and 988ab1c.

📒 Files selected for processing (1)
  • Fournos_Design_Document.md

📝 Walkthrough

Walkthrough

The design document adds a “Timeouts” section covering Fournos PipelineRun deadlines, Tekton TaskRun defaults, and an oc patch example for changing the cluster-wide default.

Changes

Timeout documentation

Layer / File(s) Summary
Add Tekton timeout guidance
Fournos_Design_Document.md
Documents pipeline, task, and finally-task timeouts, explains default-timeout-minutes behavior, and provides an oc patch example.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: lgtm

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: documenting Tekton timeout configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Fournos_Design_Document.md`:
- Around line 331-340: The cluster-wide Tekton timeout guidance should
distinguish older behavior from current precedence. Update the section around
“Cluster-wide Tekton default” to state that
config-defaults.default-timeout-minutes is only relevant for clusters with older
Tekton behavior; on current Tekton versions, the PipelineRun timeouts.tasks
value takes precedence and covers generated TaskRuns without explicit timeouts.
Retain the oc patch command only as an older-cluster workaround and align its
explanation with the documented 24h task timeout.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e39e613c-74b7-4b8c-b440-0e1047ac1939

📥 Commits

Reviewing files that changed from the base of the PR and between a7c515f and f93fcb7.

📒 Files selected for processing (1)
  • Fournos_Design_Document.md

Comment thread Fournos_Design_Document.md Outdated
Co-authored-by: Cursor <cursoragent@cursor.com>
@kpouget
kpouget merged commit 1f27f6c into openshift-psap:main Jul 30, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants