Skip to content

maintenance: fix the linter complains - #109

Merged
kpouget merged 6 commits into
openshift-psap:mainfrom
kpouget:fix
Jul 30, 2026
Merged

maintenance: fix the linter complains#109
kpouget merged 6 commits into
openshift-psap:mainfrom
kpouget:fix

Conversation

@kpouget

@kpouget kpouget commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Refactor

    • Standardized UTC timestamp handling across job tracking, scheduling, and Kubernetes operations.
    • Improved code formatting, import organization, and internal readability without changing existing behavior.
    • Clarified logging and configuration code presentation while preserving current settings and messages.
  • API

    • Added reconcile_stopping to the publicly exported handler functions.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kpouget for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kpouget, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 59fbbff9-6f76-4996-ac86-8357e5e19864

📥 Commits

Reviewing files that changed from the base of the PR and between e92b911 and b678fc9.

📒 Files selected for processing (8)
  • hacks/sync_vault_secrets.py
  • pyproject.toml
  • tests/conftest.py
  • tests/forge/deploy/orchestration/ci.py
  • tests/forge/deploy/orchestration/cli.py
  • tests/forge/deploy/orchestration/deploy.py
  • tests/forge/deploy/orchestration/utils.py
  • tests/test_exclusive.py
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 77.78% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the maintenance-focused lint/formatting cleanup in this PR, though the wording is a bit unpolished.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kpouget kpouget changed the title maintenance: fix github action errors maintenance: fix the linter issue Jul 30, 2026
@kpouget kpouget changed the title maintenance: fix the linter issue maintenance: fix the linter complains Jul 30, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@fournos-ui/app/main.py`:
- Around line 783-790: Update the replacement flow around
k8s_client.delete_cronjob so a deletion failure is not swallowed or treated as
success. When deleting edit_target raises, delete the newly created CronJob as
compensation, then re-raise or otherwise propagate the failure so the UI does
not redirect as though replacement succeeded.

In `@fournos/__main__.py`:
- Line 22: Update the module-level import of main from kopf.cli in
fournos.__main__ so it occurs before any executable runtime code, or restore the
file’s targeted E402 suppression. Ensure plain Ruff checks for fournos/ and
tests/ pass without changing the module’s behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b300c937-deeb-4450-83a4-47f6b9bf8253

📥 Commits

Reviewing files that changed from the base of the PR and between 1f27f6c and e92b911.

📒 Files selected for processing (17)
  • fournos-ui/app/config.py
  • fournos-ui/app/db.py
  • fournos-ui/app/forge_discovery.py
  • fournos-ui/app/k8s_client.py
  • fournos-ui/app/main.py
  • fournos-ui/app/watcher.py
  • fournos/__init__.py
  • fournos/__main__.py
  • fournos/handlers/__init__.py
  • fournos/handlers/lifecycle.py
  • fournos/handlers/status.py
  • fournos/operator.py
  • hacks/sync_vault_secrets.py
  • tests/forge/deploy/orchestration/ci.py
  • tests/forge/deploy/orchestration/cli.py
  • tests/forge/deploy/orchestration/deploy.py
  • tests/forge/deploy/orchestration/utils.py

Comment thread fournos-ui/app/main.py
Comment thread fournos/__main__.py
@kpouget

kpouget commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

all the tests are green, merging 👍🏻

@kpouget
kpouget merged commit a863a66 into openshift-psap:main Jul 30, 2026
4 of 5 checks passed
@kpouget
kpouget deleted the fix branch July 30, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant