maintenance: fix the linter complains - #109
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@fournos-ui/app/main.py`:
- Around line 783-790: Update the replacement flow around
k8s_client.delete_cronjob so a deletion failure is not swallowed or treated as
success. When deleting edit_target raises, delete the newly created CronJob as
compensation, then re-raise or otherwise propagate the failure so the UI does
not redirect as though replacement succeeded.
In `@fournos/__main__.py`:
- Line 22: Update the module-level import of main from kopf.cli in
fournos.__main__ so it occurs before any executable runtime code, or restore the
file’s targeted E402 suppression. Ensure plain Ruff checks for fournos/ and
tests/ pass without changing the module’s behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b300c937-deeb-4450-83a4-47f6b9bf8253
📒 Files selected for processing (17)
fournos-ui/app/config.pyfournos-ui/app/db.pyfournos-ui/app/forge_discovery.pyfournos-ui/app/k8s_client.pyfournos-ui/app/main.pyfournos-ui/app/watcher.pyfournos/__init__.pyfournos/__main__.pyfournos/handlers/__init__.pyfournos/handlers/lifecycle.pyfournos/handlers/status.pyfournos/operator.pyhacks/sync_vault_secrets.pytests/forge/deploy/orchestration/ci.pytests/forge/deploy/orchestration/cli.pytests/forge/deploy/orchestration/deploy.pytests/forge/deploy/orchestration/utils.py
|
all the tests are green, merging 👍🏻 |
Summary by CodeRabbit
Refactor
API
reconcile_stoppingto the publicly exported handler functions.