Skip to content

Fix resolve job template - #65

Merged
avasilevskii merged 1 commit into
openshift-psap:mainfrom
avasilevskii:fix-resolving-phase
Apr 28, 2026
Merged

Fix resolve job template#65
avasilevskii merged 1 commit into
openshift-psap:mainfrom
avasilevskii:fix-resolving-phase

Conversation

@avasilevskii

@avasilevskii avasilevskii commented Apr 28, 2026

Copy link
Copy Markdown

Based on #55 PR comments

Summary by CodeRabbit

  • Chores
    • Updated container image pull policy to ensure fresh images are used on every job run
    • Enhanced automated step configuration to support dynamic environment-based execution

Signed-off-by: avasilev <avasilev@redhat.com>
@openshift-ci

openshift-ci Bot commented Apr 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ashishkamra for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b1af8ae5-17c4-457f-8493-876a6411a816

📥 Commits

Reviewing files that changed from the base of the PR and between 112920c and 9089489.

📒 Files selected for processing (1)
  • config/forge/resolve_job.yaml

📝 Walkthrough

Walkthrough

A Kubernetes Job configuration is updated to always pull the resolve container image and introduce a new FOURNOS_STEP environment variable. The command is refactored to use the environment variable instead of a hard-coded step identifier.

Changes

Cohort / File(s) Summary
Container Image & Environment Configuration
config/forge/resolve_job.yaml
Set imagePullPolicy to Always for the resolve container. Add FOURNOS_STEP environment variable set to resolve-fournos-config. Refactor the bin/run_ci command to execute the CI resolve step using the $FOURNOS_STEP variable instead of a hard-coded step identifier.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A rabbit hops with glee,
Fresh images pulled, now wild and free,
Variables dance where values were stone,
Flexibility blooms where hard-code had grown! 📦✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix resolve job template' is vague and generic, lacking specificity about what is being fixed in the resolve job template. Consider revising the title to be more specific, such as 'Update resolve job template to always pull image and use FOURNOS_STEP environment variable' to better convey the actual changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@avasilevskii avasilevskii mentioned this pull request Apr 28, 2026
@kpouget

kpouget commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

🙏🏻
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2026
@avasilevskii
avasilevskii merged commit 08736c2 into openshift-psap:main Apr 28, 2026
4 of 5 checks passed
@avasilevskii
avasilevskii deleted the fix-resolving-phase branch April 28, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants