Adjust tags in image-push GHA - #80
Conversation
Signed-off-by: avasilev <avasilev@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThe CI workflow ChangesImage Push Workflow Tagging
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
lgtm, just a minor comment related to the tag name size |
Signed-off-by: avasilev <avasilev@redhat.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/image-push.yaml:
- Around line 22-24: The release workflow currently appends "stable" and the
release tag name to TAGS but omits the literal "release" alias; update the block
that checks if github.event_name == "release" (the if [[ "${{ github.event_name
}}" == "release" ]] clause) to also append the literal "release" token to the
TAGS variable (e.g., include "release" alongside "stable" and ${{
github.event.release.tag_name }}) so published images get the explicit "release"
tag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 366e5049-0e21-46fe-bb25-8d6a262bebb2
📒 Files selected for processing (1)
.github/workflows/image-push.yaml
|
thanks, |
Preparation step for #8.
Change of image push behavior and tags:
lateststag.stableandreleasetag.Summary by CodeRabbit
latestwith commit identifiers for development builds,stablewith version numbers for production releases.