WIP POC regression indicators #176
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if abs(z_score) > self.threshold: | ||
| if z_score < 0: | ||
| return -1 | ||
| else: | ||
| return 1 | ||
| else: | ||
| return 0 |
There was a problem hiding this comment.
if abs(z_score) <= self.threshold:
status = 0 # in comment: what 0 means?
elif z_score < 0:
status = -1 # in comment: what -1 means?
else:
status = 1 # in comment: what -1 means?
return status
maybe an enum could be useful here? 🤔
There was a problem hiding this comment.
hum, the enum is already there, at the top :D
| return 0 | ||
|
|
||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
when ready for merging, can you move this out of this file?
| regression_return_codes = { | ||
| "POS_REG": 1, | ||
| "NEG_REG": -1, | ||
| "NONE": 0, | ||
| "UNDEF": 2, | ||
| } |
There was a problem hiding this comment.
can you turn this into a Python enum, and make sure that the string ends up in the final JSON (not the int)
and if you can use full words instead of abbreviations :)
There was a problem hiding this comment.
@kpouget Thanks for the feedback! I actually thought I closed this PR, this was a precursor to the matbench PR. This is all old code and has been adapted into matrix-benchmarking :)
| x_var="_source.@timestamp", | ||
| y_var="_source.value", |
There was a problem hiding this comment.
I'm not sure to understand how (nor where) this is used? 🤔
_source.... should be internal OpenSearch, this module should not receive OpenSearch values
Some framework to create a number of different regression indicators, and a placeholder for potentially some future indicator that uses polynomial regression. Hoping to use this to discuss more about the design of the Regression portion @kpouget @ccamacho