Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modelcars] add role to build image #594

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

drewrip
Copy link
Contributor

@drewrip drewrip commented Nov 20, 2024

I've got this working locally but need to make sure it works in the CI

Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dagrayvid for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

---
entrypoint: '{{ role_path }}/files/entrypoint.sh'
pod_template: 'templates/pod.yml.j2'
pvc_template: 'templates/pvc.yml.j2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the github action:

23:48:40 ERROR [validate_role_files.py:101] pvc_template: templates/pvc.yml.j2 --> not found

I think you don't want this line

@kpouget
Copy link
Contributor

kpouget commented Nov 21, 2024

thanks Drew, looks good :)
minor comments, you need to regenerate the auto-generate files (I need to update the doc ...)

./run_toolbox.py repo generate_toolbox_related_files

and remove the PVC variable

with that fixed, good to merge from my POV

@drewrip drewrip force-pushed the modelcars branch 2 times, most recently from f8a9fb0 to 6930a5f Compare November 22, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants