[llm_load_test] Make more generic for testing on other platforms #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kpouget
force-pushed
the
llm-load-test
branch
4 times, most recently
from
6cb5f64 to
78bae64
Compare
…command and disabling the timeout on MacOS (command not provided by the OS ...)
…onfig.yaml: pass the model_id to openai_plugin config and preserve the historical behavior (for kserve/vllm)
kpouget
force-pushed
the
llm-load-test
branch
from
78bae64 to
5b390a2
Compare
kpouget
changed the title
|
Hello @mcharanrm @dagrayvid , could we get this PR tested to confirm that it doesn't break anything on the KServe testing? would be nice if we could have it merged asap |
dagrayvid
reviewed
Feb 14, 2025
| @@ -22,7 +22,7 @@ plugin_options: | |||
| {% if llm_load_test_run_plugin == 'openai_plugin' %} | |||
| host: "{{ llm_load_test_run_interface }}://{{ llm_load_test_run_host}}:{{ llm_load_test_run_port}}" | |||
| endpoint: "{{ llm_load_test_run_endpoint }}" | |||
| model_name: "/mnt/models/" | |||
| model_name: "{{ llm_load_test_run_model_id }}" | |||
There was a problem hiding this comment.
I think you can move this up out of the if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocating the llm-load-test visualization to a more logical place.
(I want to use the
llm-load-testproject outside of thekserveproject)/cc @mcharanrm