Adding Mapt script tool #2
Conversation
Signed-off-by: Francisco Herrera <[email protected]>
Signed-off-by: Francisco Herrera <[email protected]>
mapt_cluster/README.md
Outdated
| ### Required Tools | ||
| - **Container Engine**: Podman (recommended) or Docker | ||
| - **AWS CLI**: Required when using S3 backing (CI environments) | ||
| - **Pull Secret**: OpenShift pull secret file for cluster creation |
There was a problem hiding this comment.
You've mentioned the "pull secret" in "Required Credentials".
Probably, it could be removed from here, as it's not a tool.
|
|
||
| # Custom cluster configuration | ||
| export CLUSTER_NAME="my-test-cluster" | ||
| export CLUSTER_VERSION="4.18.0" |
There was a problem hiding this comment.
Since currently, specifying the patch version of the cluster is required, it there a place when available versions could be fetched?
If so, worth mention it here.
There was a problem hiding this comment.
I added a note in the read me
mapt_cluster/README.md
Outdated
| |--------|-------------| | ||
| | `-c, --create-only` | Create cluster only (don't delete) | | ||
| | `-d, --delete-only` | Delete cluster only (don't create) | | ||
| | `-b, --both` | Create and delete cluster (default) | |
There was a problem hiding this comment.
I think it worth explain, what is "create and delete" cluster flow.
In my point of view, as someone who looking at it for the first time, I'm not quite understand, what is - create and delete flow.
Shouldn't we first create the cluster, then run the required testing and only then delete the cluster?
There was a problem hiding this comment.
Yeah, the both is to only test the entire workflow in case anything is broken. The idea is to have a complete workflow of creation and deletion
mapt_cluster/README.md
Outdated
|
|
||
| | Option | Description | | ||
| |--------|-------------| | ||
| | `-c, --create-only` | Create cluster only (don't delete) | |
There was a problem hiding this comment.
Why to not make the arguments just - "--create" and "--delete"?
mapt_cluster/create_mapt_cluster.sh
Outdated
| container_exists() { | ||
| local container_name="$1" | ||
| local engine="${CONTAINER_ENGINE:-podman}" | ||
| $engine ps -a --format "{{.Names}}" | grep -q "^${container_name}$" 2>/dev/null |
There was a problem hiding this comment.
Isn't it better to surround the var with double quotes here and below?
Signed-off-by: Francisco Herrera <[email protected]>
Signed-off-by: Francisco Herrera <[email protected]>
Signed-off-by: Francisco Herrera <[email protected]>
| ``` | ||
|
|
||
| **Finding Available OpenShift Versions**: To find available OpenShift versions with patch numbers, you can: | ||
| - Check using the AWS clie the AMI available for your account with the name openshift-local: |
| AWS_SECRET_ACCESS_KEY AWS secret key for S3 and cluster provisioning | ||
|
|
||
| OPTIONAL ENVIRONMENT VARIABLES: | ||
| AWS_DEFAULT_REGION AWS region for resources (default: us-east-1) |
There was a problem hiding this comment.
Not a critical, but the indentation in the section below is not aligned. :)
2 participants
This PR adds a standardized, reusable script for creating and managing OpenShift clusters using MAPT (Managed Application Platform Tools) across different environments: local development to CI/CD pipelines.
Key Features
For more information, please take a look at the Readme file