Skip to content

TRT-1946: Include component readiness in docs about release testing #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
May 21, 2025
Merged

TRT-1946: Include component readiness in docs about release testing #516

openshift-merge-bot merged 1 commit into from
May 21, 2025

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Jan 13, 2025 •
edited
Loading

Explain our overarching strategy for CI jobs, and how to choose between Component Readiness or Payload Blocking.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@openshift-ci openshift-ci bot requested review from jmguzik and smg247 January 13, 2025 16:53
@stbenjam stbenjam changed the title [WIP] Include component readiness in docs about release gating TRT-1946: Include component readiness in docs about release gating Jan 14, 2025
@stbenjam stbenjam changed the title TRT-1946: Include component readiness in docs about release gating TRT-1946: Include component readiness in docs about release testing Jan 14, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2025 •
edited by openshift-ci bot
Loading

@stbenjam: This pull request references TRT-1946 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Explain our overarching strategy for CI jobs, and how to choose between Component Readiness or Payload Blocking.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

deads2k
deads2k reviewed Jan 14, 2025
View reviewed changes
deads2k
deads2k reviewed Jan 14, 2025
View reviewed changes
deads2k
deads2k reviewed Jan 14, 2025
View reviewed changes
deads2k
deads2k reviewed Jan 14, 2025
View reviewed changes
deads2k
deads2k reviewed Jan 14, 2025
View reviewed changes
deads2k
deads2k reviewed Jan 14, 2025
View reviewed changes
deads2k
deads2k reviewed Jan 14, 2025
View reviewed changes
deads2k
deads2k reviewed Jan 14, 2025
View reviewed changes
deads2k
deads2k reviewed Jan 14, 2025
View reviewed changes
deads2k
deads2k reviewed Jan 14, 2025
View reviewed changes
deads2k
deads2k reviewed Jan 14, 2025
View reviewed changes
sosiouxme
sosiouxme reviewed Jan 14, 2025
View reviewed changes
@openshift-bot
Copy link

openshift-bot commented Apr 15, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2025
@stbenjam stbenjam force-pushed the release-gating branch 2 times, most recently from 94877a0 to 3685109 Compare May 16, 2025 17:44
@stbenjam
Copy link
Member Author

stbenjam commented May 16, 2025

/remove lifecycle/stale

@stbenjam
Copy link
Member Author

stbenjam commented May 19, 2025

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2025
@stbenjam
Include component readiness in docs about release blocking
fab239b 
Explain our overarching strategy for CI jobs, and how to choose between
Component Readiness or Payload Blocking.
@neisw
Copy link
Contributor

neisw commented May 20, 2025

/test links

@neisw
Copy link
Contributor

neisw commented May 20, 2025

/lgtm

Looks like other prs have had links issues too #537

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2025
@danilo-gemoli
Copy link
Contributor

danilo-gemoli commented May 21, 2025

/lgtm
/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, neisw, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2025

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 372648b into openshift:main May 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

@jmguzik jmguzik Awaiting requested review from jmguzik

@smg247 smg247 Awaiting requested review from smg247

+1 more reviewer

@sosiouxme sosiouxme sosiouxme left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@danilo-gemoli danilo-gemoli

@neisw neisw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@stbenjam @openshift-ci-robot @openshift-bot @neisw @danilo-gemoli @sosiouxme @deads2k