Allow requests for ephemeral-storage in validation/config.go

openshift · Dec 11, 2024 · d57b243 · d57b243
1 parent 3f0b176
commit d57b243
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/pkg/validation/config.go b/pkg/validation/config.go
@@ -567,7 +567,7 @@ func validateResourceList(fieldRoot string, list api.ResourceList) []error {
 	var numInvalid int
 	for key := range list {
 		switch key {
-		case "cpu", "memory", api.ShmResource, api.NvidiaGPUResource:
+		case "cpu", "memory", "ephemeral-storage", api.ShmResource, api.NvidiaGPUResource:
 			quantity, err := resource.ParseQuantity(list[key])
 			if err != nil {
 				validationErrors = append(validationErrors, fmt.Errorf("%s.%s: invalid quantity: %w", fieldRoot, key, err))

diff --git a/pkg/validation/config_test.go b/pkg/validation/config_test.go
@@ -249,6 +249,20 @@ func TestValidateResources(t *testing.T) {
 			},
 			expectedErr: true,
 		},
+		{
+			name: "valid ephemeral-storage value passes",
+			input: api.ResourceConfiguration{
+				"*": api.ResourceRequirements{
+					Requests: api.ResourceList{
+						"ephemeral-storage": "60Gi",
+					},
+					Limits: api.ResourceList{
+						"ephemeral-storage": "100Gi",
+					},
+				},
+			},
+			expectedErr: false,
+		},
 		{
 			name: "valid shm value passes",
 			input: api.ResourceConfiguration{