Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Hat Konflux update osc-podvm-payload #19

Open
wants to merge 2 commits into
base: osc-release
Choose a base branch
from

Conversation

red-hat-konflux[bot]
Copy link

Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content /ok-to-test

For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun

To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

@littlejawa
Copy link

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 7, 2025
@littlejawa
Copy link

/retest

@littlejawa littlejawa force-pushed the appstudio-osc-podvm-payload branch from b765eae to 42f9c2f Compare February 7, 2025 14:14
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2025
@littlejawa littlejawa force-pushed the appstudio-osc-podvm-payload branch from 42f9c2f to 9ca5104 Compare February 7, 2025 14:17
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2025
@littlejawa
Copy link

/retest

@littlejawa littlejawa force-pushed the appstudio-osc-podvm-payload branch from 383b2ab to 9ca5104 Compare February 10, 2025 12:58
@littlejawa
Copy link

/retest

red-hat-konflux and others added 2 commits February 14, 2025 14:57
@littlejawa littlejawa force-pushed the appstudio-osc-podvm-payload branch from 9ca5104 to 0f06898 Compare February 14, 2025 13:57
@spotlesstofu
Copy link

spotlesstofu commented Feb 14, 2025

As anticipated on Slack, my proposal here is to set the guest-components submodule at f9aa889.

This allows to remove the few commits that depend on a newer Rust version (LazyLock) and the build succeeds on UBI9.

@littlejawa
Copy link

As anticipated on Slack, my proposal here is to set the guest-components submodule at f9aa889.
This allows to remove the few commits that depend on a newer Rust version (LazyLock) and the build succeeds on UBI9.

Yes. I tend to agree.

A bit more context (for future reference):
Initially, when we found that the rust version we need was not available in our builder, we discussed this possibility.
We ruled it out, because we want to use a stable tag when we build, and want to avoid changing anything if we don't need to.
We decided to ask for a new build root on the CPaaS side, managed to get it, and now we can build the guest-components v0.11 code with rust 1.84 on CPaaS.

Now here with Konflux:

  • we don't have access to the CPaaS build root
  • we are not supposed to use the centos:stream9 image as a builder
  • we should not install a different toolchain manually (e.g: using rustup)

Based on this, I think we can consider removing the couple commits that introduce the dependency to rust 1.80.

These commits are changing the code to use a new rust stdlib lock mecanism (LazyLock), in place of the one that we were using before.
Removing them should not have an impact on the features we provide.

I will make that change and see how it goes. It will impact only the Konflux build anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants