Skip to content

NO-JIRA: Write provider version to openshift/provider-version.mk #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RadekManak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-JIRA: Write provider version to openshift/provider-version.mk #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion hack/rebasebot-hook-scripts/generate-ocp-manifests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,15 @@ main(){
exit 1
fi

# Set PROVIDER_VERSION using the REBASEBOT_SOURCE tag, which corresponds to the provider's version number
# Set PROVIDER_VERSION using the REBASEBOT_SOURCE tag, which corresponds to the provider's version number
export PROVIDER_VERSION="${REBASEBOT_SOURCE}"

# Write provider version to a .mk file that can be included by Makefiles
cat > openshift/provider-version.mk <<EOF
# This file is generated by rebasebot. Do not edit.
PROVIDER_VERSION ?= ${PROVIDER_VERSION}
EOF
Comment on lines +35 to +39
Copy link
Member

@damdo damdo Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an idiomatic pattern?


pushd openshift
make ocp-manifests
popd
Expand Down