Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1593: Update api extensions to upstream #215

Merged
merged 1 commit into from
Jul 30, 2024
Merged

STOR-1593: Update api extensions to upstream #215

merged 1 commit into from
Jul 30, 2024

Conversation

dfajmon
Copy link
Contributor

@dfajmon dfajmon commented Jul 25, 2024 •
edited
Loading

Update api extensions to upstream which implemented way of validating sources instead of using webhook.
This is change is needed by openshift/csi-external-snapshotter#156.

@openshift/storage

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 25, 2024 •
edited by openshift-ci bot
Loading

@dfajmon: This pull request references STOR-1593 which is a valid jira issue.

In response to this:

Update api extensions to upstream which implemented way of validating sources instead of using webhook.
This is change is needed by openshift/csi-external-snapshotter#156.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 25, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 25, 2024 •
edited by openshift-ci bot
Loading

@dfajmon: This pull request references STOR-1593 which is a valid jira issue.

In response to this:

Update api extensions to upstream which implemented way of validating sources instead of using webhook.
This is change is needed by openshift/csi-external-snapshotter#156.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfajmon
Copy link
Contributor Author

dfajmon commented Jul 26, 2024

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 26, 2024

@dfajmon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

/lgtm
/approve
/label px-approved
/label docs-approved
/label qe-approved
@duanwei33 testing should happen in openshift/csi-external-snapshotter#156

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Jul 30, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 30, 2024 •
edited by openshift-ci bot
Loading

@dfajmon: This pull request references STOR-1593 which is a valid jira issue.

In response to this:

Update api extensions to upstream which implemented way of validating sources instead of using webhook.
This is change is needed by openshift/csi-external-snapshotter#156.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 953249d into openshift:master Jul 30, 2024
12 checks passed
@dfajmon dfajmon deleted the apiextensions branch July 30, 2024 11:34
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-csi-snapshot-controller-operator
This PR has been included in build ose-cluster-csi-snapshot-controller-operator-container-v4.18.0-202407301115.p0.g953249d.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dfajmon @openshift-ci-robot @jsafrane @openshift-bot