Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]add_scrnario_OCP-71253 #1192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP]add_scrnario_OCP-71253 #1192

wants to merge 1 commit into from

Conversation

geliu2016
Copy link

@geliu2016 geliu2016 commented Feb 1, 2024 •
edited
Loading

@tjungblu I added qe test scenario to e2e test, could you please take a look?
cc: @sandeepknd

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: geliu2016
Once this PR has been reviewed and has the lgtm label, please assign elbehery for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tjungblu
tjungblu reviewed Feb 1, 2024
View reviewed changes
Makefile
@@ -47,4 +52,13 @@ test-e2e: GO_TEST_FLAGS += -v
test-e2e: GO_TEST_FLAGS += -timeout 2h
test-e2e: GO_TEST_FLAGS += -p 1
test-e2e: test-unit
test-e2e:
go test \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geliu2016 - dunno if you saw this already, but @Elbehery added a very similar test in test/e2e/backup_script_test.go already. I believe you could reuse almost everything in there to write a testcase for that bug.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tjungblu Yes, I saw there is similar test in backup_script_test.go already, and it checking the etcd backup feature with go function mode, and QE's test are focus on more complex scenarios, and QE using ginkgo mod to design test case, as I reviewed other sub component teams' e2e, they are also organize e2e test with go functions(Dev's prefer) and ginkgo(QE's prefer), it could co-exist, and I wish this backup case is a beginning, we will contribute QE's scenarios with this ginkgo framework.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to have ginkgo tests in origin: https://github.com/openshift/origin/tree/master/test/extended/etcd

Otherwise this causes too much confusion and I don't want to maintain two test frameworks in here.

tjungblu
tjungblu reviewed Feb 1, 2024
View reviewed changes
go.mod Outdated
@@ -3,31 +3,34 @@ module github.com/openshift/cluster-etcd-operator
go 1.20

require (
github.com/davecgh/go-spew v1.1.1
github.com/cert-manager/cert-manager v1.14.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what on earth do we need cert manager for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha, correct it.

lance5890
lance5890 reviewed Feb 1, 2024
View reviewed changes
test/e2e/etcd_scenario_test.go Outdated
By("Wait for debug pod to be in Running phase.")
err = wait.PollUntilContextTimeout(context.Background(), time.Second, 30*time.Minute, true, func(ctx context.Context) (done bool, err error) {
pods, err := clientSet.CoreV1Interface.Pods(debugNamespace).List(ctx, metav1.ListOptions{})
if err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if err != nil && !apierrors.IsNotFound(err) {
return false, err
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

@geliu2016: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 74e1ea4 link true /test verify
ci/prow/e2e-aws-ovn-serial 74e1ea4 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-etcd-recovery 74e1ea4 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-operator-fips 74e1ea4 link true /test e2e-operator-fips
ci/prow/e2e-operator 74e1ea4 link true /test e2e-operator
ci/prow/e2e-aws-ovn-single-node 74e1ea4 link true /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-qe-no-capabilities 74e1ea4 link false /test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance5890 lance5890 lance5890 left review comments

@tjungblu tjungblu tjungblu left review comments

@dusk125 dusk125 Awaiting requested review from dusk125

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@geliu2016 @openshift-merge-robot @openshift-bot @lance5890 @tjungblu