OCPBUGS-34525: Add "check-api-lb" subcommand #1678
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
vrutkovs
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
vrutkovs
force-pushed
the
check-api-lb
branch
9 times, most recently
from
8576a70
to
4b4bb2e
Compare
vrutkovs
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
pkg/cmd/checkapilb/cmd.go
Outdated
|
|
||
| attempt := 0 | ||
| return wait.PollImmediateUntil(time.Second, func() (done bool, err error) { | ||
| retryCtx, retryCancel := context.WithTimeout(context.Background(), time.Second) |
There was a problem hiding this comment.
A 1 second context timeout seems too short.
There was a problem hiding this comment.
Right, I can make it 5 secs just to be safe
|
we need to check the @tkashem has a bash version in openshift/installer#8429 |
This command is used by bootstrap to verify that bootstrap instance is ready to be shutdown
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
vrutkovs
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@vrutkovs: This pull request references Jira Issue OCPBUGS-34525, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Done |
|
/test e2e-aws-ovn-single-node |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
/remove-lifecycle rotten |
openshift-ci
bot
removed
the
lifecycle/rotten
This command is used by bootstrap to verify that bootstrap instance is ready to be shutdown.
Similar to installer bash script, this checks that
kubernetesendpoint has at least 2 entries andapi/api-intendpoints can dogetusing installer kubeconfig.Tested via
test e2e 4.16,https://github.com/openshift/cluster-kube-apiserver-operator/pull/1678,https://github.com/openshift/installer/pull/8404 vsphereDo we want to switch to endpointslices to get information about endpoint readiness?