Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library-go #1753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update library-go #1753

wants to merge 1 commit into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Oct 11, 2024

To address the recent regression faced here.

Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rexagod
Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rexagod
Copy link
Member Author

rexagod commented Oct 11, 2024

/retest

@p0lyn0mial
Copy link
Contributor

I think the failures are due to a compilation error:

 github.com/openshift/cluster-kube-apiserver-operator/pkg/operator
pkg/operator/starter.go:139:3: not enough arguments in call to genericoperatorclient.NewStaticPodOperatorClient
	have (*"k8s.io/client-go/rest".Config, "k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime/schema".GroupVersionKind, func(obj *unstructured.Unstructured, fieldManager string) (*"github.com/openshift/client-go/operator/applyconfigurations/operator/v1".StaticPodOperatorSpecApplyConfiguration, error), func(obj *unstructured.Unstructured, fieldManager string) (*"github.com/openshift/client-go/operator/applyconfigurations/operator/v1".StaticPodOperatorStatusApplyConfiguration, error))
	want ("k8s.io/utils/clock".PassiveClock, *"k8s.io/client-go/rest".Config, "k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime/schema".GroupVersionKind, genericoperatorclient.StaticPodOperatorSpecExtractorFunc, genericoperatorclient.StaticPodOperatorStatusExtractorFunc)

@rexagod
Copy link
Member Author

rexagod commented Oct 11, 2024

Ah, there's more apparently (go vet still fails), looking into it.

To address the recent regression faced here.

Signed-off-by: Pranshu Srivastava <[email protected]>
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

@rexagod: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 4a714c9 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 4a714c9 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-metal-single-node-live-iso 4a714c9 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-gcp-operator 4a714c9 link true /test e2e-gcp-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants