MON-3940: Add the collection of MTV migration metrics to Telemetry #2743

solenoci · 2025-11-11T14:34:02Z

Continuation of https://issues.redhat.com/browse/MON-3940.

Previous outdated PR: #2461

As the previous PR was stale and the person who created the PR is not longer working on it, I recreated the PR.

Any required changes will go into this PR.

Ref: https://issues.redhat.com/browse/MTV-1370

I added CHANGELOG entry for this change.
No user facing changes, so no entry in CHANGELOG was needed.

Continuation of https://issues.redhat.com/browse/MON-3940. Previous outdated PR: openshift#2461 As the previous PR was stale and the person who created the PR is not longer working on it, I recreated the PR. Ref: https://issues.redhat.com/browse/MTV-1370 Signed-off-by: Stefan Olenocin <[email protected]>

openshift-ci-robot · 2025-11-11T14:34:06Z

@solenoci: This pull request references MON-3940 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Continuation of https://issues.redhat.com/browse/MON-3940.

Previous outdated PR: #2461

As the previous PR was stale and the person who created the PR is not longer working on it, I recreated the PR.

Ref: https://issues.redhat.com/browse/MTV-1370

I added CHANGELOG entry for this change.

No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-11-11T14:35:25Z

Hi @solenoci. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-11-11T14:39:49Z

@solenoci: This pull request references MON-3940 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Continuation of https://issues.redhat.com/browse/MON-3940.

Previous outdated PR: #2461

As the previous PR was stale and the person who created the PR is not longer working on it, I recreated the PR.

Any required changes will go into this PR.

Ref: https://issues.redhat.com/browse/MTV-1370

I added CHANGELOG entry for this change.

No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier · 2025-11-12T14:36:42Z

manifests/0000_50_cluster-monitoring-operator_04-config.yaml

+    #
+    # cluster:mtv_migrations_status_total:max is the total number of VM migrations running on the cluster,
+    # labeled with {status}, {provider}, {mode}, and {target}.
+    - '{__name__="cluster:mtv_migrations_status_total:max"}'


ideally we want to ensure that we only send metrics with known label values (I'm not sure about the possible values for the provider` label).

Suggested change

- '{__name__="cluster:mtv_migrations_status_total:max"}'

- '{__name__="cluster:mtv_migrations_status_total:max",provider=~"ova|vsphere|openstack|openshift|ovirt"},target=~"Local|Remote",mode=~"Cold|Warm",status=~"Succeeded|Failed|Canceled"'

They are corrrect

However we will add another provider soon, EC2

Signed-off-by: Stefan Olenocin <[email protected]>

solenoci · 2025-11-12T15:15:11Z

Added planned provider that we are actively working on, but do not have the metric yet, and RCM migration mode (same story) for which we will add the metric really soon.

simonpasquier

/lgtm
/hold for a final review by @janisz

simonpasquier · 2025-11-12T15:37:17Z

/ok-to-test

openshift-ci · 2025-11-12T15:37:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier, solenoci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

simonpasquier · 2025-11-12T15:37:32Z

/cc @jan--f

janisz · 2025-11-12T16:31:17Z

@simonpasquier Are you sure you'd like me to review? I think I miss the context

Documentation/data-collection.md

simonpasquier · 2025-11-13T09:48:57Z

sorry @janisz that was a mistake!

openshift-ci · 2025-11-13T11:29:20Z

New changes are detected. LGTM label has been removed.

juzhao · 2025-11-13T13:03:25Z

Documentation/data-collection.md

+    # - target: "Local" or "Remote"
+    # - mode: "Cold", "Warm" or "RCM"
+    # - status: "Suceeded", "Failed" or "Canceled"
+    - '{__name__="cluster:mtv_migrations_status_total:max", provider=~"ova|vsphere|openstack|openshift|ovirt|awsec2", target=~"Local|Remote", mode=~"Cold|Warm|RCM", status=~"Succeeded|Failed|Canceled"}'


Suggested change

- '{__name__="cluster:mtv_migrations_status_total:max", provider=~"ova|vsphere|openstack|openshift|ovirt|awsec2", target=~"Local|Remote", mode=~"Cold|Warm|RCM", status=~"Succeeded|Failed|Canceled"}'

- '{__name__="cluster:mtv_migrations_status_total:sum", provider=~"ova|vsphere|openstack|openshift|ovirt|awsec2", target=~"Local|Remote", mode=~"Cold|Warm|RCM", status=~"Succeeded|Failed|Canceled"}'

should change for all, replace all cluster:mtv_migrations_status_total:max to cluster:mtv_migrations_status_total:sum

Right, sorry, changed for all.

Co-authored-by: Junqi Zhao <[email protected]>

openshift-ci · 2025-11-13T17:04:45Z

@solenoci: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/versions	`3c7c43b`	link	false	`/test versions`
ci/prow/ginkgo-tests	`3c7c43b`	link	false	`/test ginkgo-tests`
ci/prow/okd-scos-e2e-aws-ovn	`3c7c43b`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-aws-ovn-techpreview	`3c7c43b`	link	true	`/test e2e-aws-ovn-techpreview`
ci/prow/generate	`3c7c43b`	link	true	`/test generate`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 11, 2025

openshift-ci bot requested review from rexagod and simonpasquier November 11, 2025 14:35

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 11, 2025

solenoci mentioned this pull request Nov 11, 2025

MON-3940: Add the collection of MTV migration metrics to Telemetry #2461

Open

simonpasquier reviewed Nov 12, 2025

View reviewed changes

Add planned provider and migration mode

84f8d13

Signed-off-by: Stefan Olenocin <[email protected]>

simonpasquier reviewed Nov 12, 2025

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2025

openshift-ci bot assigned simonpasquier Nov 12, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2025

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 12, 2025

openshift-ci bot requested a review from jan--f November 12, 2025 15:37

openshift-ci bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 12, 2025

juzhao reviewed Nov 13, 2025

View reviewed changes

Documentation/data-collection.md Outdated Show resolved Hide resolved

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025

juzhao reviewed Nov 13, 2025

View reviewed changes

Update the suffix to sum

3c7c43b

Co-authored-by: Junqi Zhao <[email protected]>

solenoci force-pushed the mtv-1370 branch from ed17731 to 3c7c43b Compare November 13, 2025 13:32

	- '{__name__="cluster:mtv_migrations_status_total:max"}'
	- '{__name__="cluster:mtv_migrations_status_total:max",provider=~"ova\|vsphere\|openstack\|openshift\|ovirt"},target=~"Local\|Remote",mode=~"Cold\|Warm",status=~"Succeeded\|Failed\|Canceled"'

MON-3940: Add the collection of MTV migration metrics to Telemetry #2743

Are you sure you want to change the base?

MON-3940: Add the collection of MTV migration metrics to Telemetry #2743

Uh oh!

Conversation

solenoci commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 11, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Nov 11, 2025

Uh oh!

openshift-ci-robot commented Nov 11, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simonpasquier Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

solenoci Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

solenoci Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

solenoci commented Nov 12, 2025

Uh oh!

simonpasquier left a comment

Choose a reason for hiding this comment

Uh oh!

simonpasquier commented Nov 12, 2025

Uh oh!

openshift-ci bot commented Nov 12, 2025

Uh oh!

simonpasquier commented Nov 12, 2025

Uh oh!

janisz commented Nov 12, 2025

Uh oh!

Uh oh!

simonpasquier commented Nov 13, 2025

Uh oh!

openshift-ci bot commented Nov 13, 2025

Uh oh!

juzhao Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solenoci Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

solenoci commented Nov 11, 2025 •

edited

Loading

openshift-ci-robot commented Nov 11, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 11, 2025 •

edited by openshift-ci bot

Loading

juzhao Nov 13, 2025 •

edited

Loading