Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-2035: Set up Azure authentication with cert for ARO HCP #2522

Merged
merged 1 commit into from
Oct 24, 2024
Merged

HOSTEDCP-2035: Set up Azure authentication with cert for ARO HCP #2522

merged 1 commit into from
Oct 24, 2024

Conversation

bryan-cox
Copy link
Member

Passes the appropriate env var in order to authenticate with Azure with certs for ARO HCP

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bryan-cox bryan-cox mentioned this pull request Oct 7, 2024
Closed
@bryan-cox bryan-cox changed the title Set up Azure authentication with cert for ARO HCP HOSTEDCP-1994: Set up Azure authentication with cert for ARO HCP Oct 9, 2024
@bryan-cox bryan-cox marked this pull request as ready for review October 9, 2024 18:37
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2024 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references HOSTEDCP-1994 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.18.0" version, but multiple target versions were set.

In response to this:

Passes the appropriate env var in order to authenticate with Azure with certs for ARO HCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2024
@openshift-ci openshift-ci bot requested review from danwinship and dougbtv October 9, 2024 18:40
@bryan-cox
Copy link
Member Author

/retest-required

1 similar comment
@bryan-cox
Copy link
Member Author

/retest-required

@bryan-cox
Copy link
Member Author

/test e2e-aws-ovn-hypershift-conformance

@bryan-cox bryan-cox marked this pull request as draft October 18, 2024 20:23
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
@bryan-cox bryan-cox changed the title HOSTEDCP-1994: Set up Azure authentication with cert for ARO HCP HOSTEDCP-2035: Set up Azure authentication with cert for ARO HCP Oct 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 19, 2024 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references HOSTEDCP-2035 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.18.0" version, but multiple target versions were set.

In response to this:

Passes the appropriate env var in order to authenticate with Azure with certs for ARO HCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member Author

/test unit
/test verify

@bryan-cox
Copy link
Member Author

I tested this PR with the following PRs and was able to deploy an Azure Hosted Cluster from an AKS management cluster:

@bryan-cox bryan-cox marked this pull request as ready for review October 19, 2024 19:44
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2024
@bryan-cox bryan-cox mentioned this pull request Oct 19, 2024
Merged
@openshift-ci openshift-ci bot requested a review from abhat October 19, 2024 19:46
@bryan-cox
Copy link
Member Author

/retest

@bryan-cox bryan-cox mentioned this pull request Oct 22, 2024
Merged
4 tasks
kyrtapz
kyrtapz reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@kyrtapz kyrtapz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

bindata/cloud-network-config-controller/managed/controller.yaml Outdated Show resolved Hide resolved
pkg/network/cloud_network.go Outdated Show resolved Hide resolved
bindata/cloud-network-config-controller/managed/controller.yaml Outdated Show resolved Hide resolved
@bryan-cox bryan-cox force-pushed the HOSTEDCP-1994 branch 2 times, most recently from f3c752a to 641289c Compare October 23, 2024 17:33
@bryan-cox bryan-cox force-pushed the HOSTEDCP-1994 branch 3 times, most recently from acde94e to df904ea Compare October 24, 2024 11:22
@bryan-cox bryan-cox force-pushed the HOSTEDCP-1994 branch 2 times, most recently from b40088d to f0b8175 Compare October 24, 2024 11:44
@bryan-cox
Set up Azure authentication with cert for ARO HCP
40e541d 
This commit passes the needed environment variables for CNCC to
authenticate with client certificate for ARO HCP deployments.

Signed-off-by: Bryan Cox <[email protected]>
@kyrtapz
Copy link
Contributor

kyrtapz commented Oct 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD de12283 and 2 for PR HEAD 40e541d in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

@bryan-cox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 40e541d link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade 40e541d link false /test 4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
ci/prow/security 40e541d link false /test security
ci/prow/e2e-ovn-hybrid-step-registry 40e541d link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-ovn-ipsec-step-registry 40e541d link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-aws-hypershift-ovn-kubevirt 40e541d link false /test e2e-aws-hypershift-ovn-kubevirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 89ee01b into openshift:master Oct 24, 2024
27 of 33 checks passed
@bryan-cox bryan-cox deleted the HOSTEDCP-1994 branch October 25, 2024 00:36
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.18.0-202410250313.p0.g89ee01b.assembly.stream.el9.
All builds following this will include this PR.

@bryan-cox
Copy link
Member Author

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link

@bryan-cox: new pull request created: #2577

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrtapz kyrtapz kyrtapz left review comments

@danwinship danwinship Awaiting requested review from danwinship

@dougbtv dougbtv Awaiting requested review from dougbtv

@abhat abhat Awaiting requested review from abhat

Assignees

@kyrtapz kyrtapz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bryan-cox @openshift-ci-robot @kyrtapz @openshift-bot @openshift-cherrypick-robot