[release-4.16] OCPBUGS-43803: Start feature migration when the cluster CNI is changed to the target type

[pliurh]

The first step in an offline migration is settingspec.migration.networkType, which triggers the cluster to update the MachineConfigPools. It also triggers feature migration, the egress IP previously assigned by the SDN will be released. At this stage, however, OVN-K is not yet deployed; the SDN continues to manage networking, allowing the egress IP functionality to remain operational. Therefore, we postpone the feature migration until after spec.default.type has been
modified. It can help to reduce the downtime for egressIP during SDN migration. The impact for live migration is similar.

[openshift-ci-robot]

@pliurh: This pull request references Jira Issue OCPBUGS-43803, which is invalid:

• expected the bug to target the "4.16.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-43803 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

It can help to reduce the downtime for egressIP during SDN migration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pliurh]

/jira refresh

[openshift-ci-robot]

@pliurh: This pull request references Jira Issue OCPBUGS-43803, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.z) matches configured target version for branch (4.16.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-44034 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-44034 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
• bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[zhaozhanqi]

pre-merge tested this and all features looks good before the network type is changed to ovn

/label qe-approved
/label cherry-pick-approved

[openshift-ci-robot]

@pliurh: This pull request references Jira Issue OCPBUGS-43803, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.z) matches configured target version for branch (4.16.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-44034 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-44034 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
• bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

It can help to reduce the downtime for egressIP during SDN migration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kyrtapz]

@pliurh is this improvement specific to offline migration? Could you please add some context in the PR description about how is this helping reduce downtime?

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pliurh
Once this PR has been reviewed and has the lgtm label, please assign kyrtapz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pliurh]

@pliurh is this improvement specific to offline migration? Could you please add some context in the PR description about how is this helping reduce downtime?

I was wrong, it can also help live migration. I updated the commit message, PTAL.

[openshift-ci]

@pliurh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-network-mtu-migration-ovn-ipv6	4570d9c	link	false	/test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-openstack-ovn	4570d9c	link	false	/test e2e-openstack-ovn
ci/prow/security	4570d9c	link	false	/test security
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec	4570d9c	link	false	/test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	4570d9c	link	false	/test e2e-vsphere-ovn-dualstack-primaryv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[pliurh]

/retest-required