Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue shorter certificates when ShortRotation featuregate is enabled #2556

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Issue shorter certificates when ShortRotation featuregate is enabled #2556

wants to merge 5 commits into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Nov 7, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign dougbtv for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs force-pushed the short-cert-rotation-featuregate branch from e9e50d0 to c8a572c Compare November 7, 2024 13:27
jluhrsen and others added 4 commits November 7, 2024 14:27
@jluhrsen @vrutkovs
SDN-5234: rebase k8s v1.31.1
612c4dc 
Update with:

go get -u github.com/openshift/build-machinery-go
go get -u k8s.io/api
go get -u k8s.io/apimachinery
go get -u k8s.io/code-generator
go get -u k8s.io/component-base
go get -u k8s.io/klog/v2
go get -u k8s.io/kube-proxy
go get -u k8s.io/utils
go get -u sigs.k8s.io/controller-runtime
go get -u github.com/openshift/api
go get -u github.com/openshift/client-go
go get -u github.com/openshift/library-go
go get -u github.com/openshift/machine-config-operator
go get -u k8s.io/apiextensions-apiserver
go get -u k8s.io/client-go
go get -u sigs.k8s.io/controller-tools
go mod tidy
go mod vendor
make verify

Build was breaking due to a change in openshift/library-go [0].
Implemented some new functions for:

genericoperatorclient.NewClusterScopedOperatorClient()
v1helpers.OperatorClient

[0] openshift/library-go#1787

Signed-off-by: Jamo Luhrsen <[email protected]>
@vrutkovs
Bump api
263a720
@vrutkovs
Issue shorter certificates when ShortRotation featuregate is enabled
0c27f49
@vrutkovs
Issue shorter certificates when ShortRotation featuregate is enabled
7e10721
@vrutkovs vrutkovs force-pushed the short-cert-rotation-featuregate branch from c8a572c to 7e10721 Compare November 7, 2024 13:28
@vrutkovs vrutkovs force-pushed the short-cert-rotation-featuregate branch from d268d10 to 7e10721 Compare November 15, 2024 11:42
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrutkovs @openshift-merge-robot @jluhrsen