[DNM] remove ipsec state disable default crypto 4.16 #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ovn-ipsec-host daemonset is not fast enough to trigger ovs-monitor-ipsec script to delete ipsec tunnel entries when east-west IPsec is disabled from API. This still keeps east west traffic with ipsec encrypted when IPsec mode is changed from full to external mode. Hence this commit cleans up ipsec entries in the ovn-ipsec-host DS prestop hook before killing ovs-monitor-ipsec script. Signed-off-by: Periyasamy Palanisamy <[email protected]> (cherry picked from commit ea18156) (cherry picked from commit 3892c72) (cherry picked from commit 7c1536d)
The previous commit deletes ipsec entries in the preStop of the ovn-ipsec container just before killing ovs-monitor-ipsec script. We never know it may cause any other potential issues when cleanup and ovs-monitor-ipsec running at the same time. hence moving ipsec cleanup logic into the sidecar container so that it happens only after ovs-monitor-ipsec is killed. Signed-off-by: Periyasamy Palanisamy <[email protected]> (cherry picked from commit e58b561) (cherry picked from commit 72c9115) (cherry picked from commit b8a047a)
The ovs-monitor-ipsec doesn't set authby, so when it calls ipsec auto --start the default ones defined at Libreswan's compile time will be used. On restart, Libreswan will use authby from libreswan.config. If libreswan.config is incompatible with the Libreswan's compiled-in defaults, then we'll have an authentication problem. But OTOH, ovs-monitor-ipsec does set ike and esp algorithms, so those may be incompatible with libreswan.config as well. Hence commenting out the "include" from libreswan.conf to avoid such conflicts. Signed-off-by: Periyasamy Palanisamy <[email protected]> (cherry picked from commit 553516e) (cherry picked from commit 36e691e) (cherry picked from commit 2e5c7d3) (cherry picked from commit cd01c95)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pperiyasamy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pperiyasamy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for QE testing.