OCPBUGS-46422: Add a ValidatingAdmissionPolicy blocking ServiceCIDR changes

[danwinship]

The ServiceCIDR API is beta (and thus available by default) in k8s 1.31, but it will not work correctly in OCP, because (among other things) we do not support dynamically updating ovn-kubernetes with changes to the service CIDRs. Thus, we need to block admins from using this API (while not interfering with kube-apiserver's own use of the API).

[openshift-ci-robot]

@danwinship: This pull request references Jira Issue OCPBUGS-46422, which is invalid:

• expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The ServiceCIDR API is beta (and thus available by default) in k8s 1.31, but it will not work correctly in OCP, because (among other things) we do not support dynamically updating ovn-kubernetes with changes to the service CIDRs. Thus, we need to block admins from using this API (while not interfering with kube-apiserver's own use of the API).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[danwinship]

/jira refresh

[openshift-ci-robot]

@danwinship: This pull request references Jira Issue OCPBUGS-46422, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-upgrade	7e3972b	link	true	/test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node	7e3972b	link	false	/test e2e-aws-ovn-single-node
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec	7e3972b	link	false	/test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-ovn-hybrid-step-registry	7e3972b	link	false	/test e2e-ovn-hybrid-step-registry
ci/prow/e2e-network-mtu-migration-ovn-ipv4	7e3972b	link	false	/test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-metal-ipi-ovn-ipv6	7e3972b	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	7e3972b	link	false	/test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-vsphere-ovn-dualstack	7e3972b	link	false	/test e2e-vsphere-ovn-dualstack
ci/prow/e2e-azure-ovn	7e3972b	link	false	/test e2e-azure-ovn
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration	7e3972b	link	false	/test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-azure-ovn-upgrade	7e3972b	link	true	/test e2e-azure-ovn-upgrade
ci/prow/4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade	7e3972b	link	false	/test 4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-serial	7e3972b	link	false	/test e2e-aws-ovn-serial
ci/prow/security	7e3972b	link	false	/test security
ci/prow/e2e-gcp-ovn-techpreview	7e3972b	link	true	/test e2e-gcp-ovn-techpreview
ci/prow/okd-scos-e2e-aws-ovn	7e3972b	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-ovn	7e3972b	link	true	/test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration	7e3972b	link	false	/test e2e-aws-ovn-local-to-shared-gateway-mode-migration
ci/prow/4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-upgrade	7e3972b	link	false	/test 4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-hypershift-ovn-kubevirt	7e3972b	link	false	/test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-network-mtu-migration-ovn-ipv6	7e3972b	link	false	/test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-ovn-step-registry	7e3972b	link	false	/test e2e-ovn-step-registry
ci/prow/e2e-aws-ovn-windows	7e3972b	link	true	/test e2e-aws-ovn-windows
ci/prow/e2e-openstack-ovn	7e3972b	link	false	/test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn-upgrade	7e3972b	link	true	/test e2e-gcp-ovn-upgrade
ci/prow/4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade	7e3972b	link	false	/test 4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
ci/prow/e2e-vsphere-ovn	7e3972b	link	false	/test e2e-vsphere-ovn
ci/prow/e2e-ovn-ipsec-step-registry	7e3972b	link	false	/test e2e-ovn-ipsec-step-registry
ci/prow/e2e-aws-ovn-hypershift-conformance	7e3972b	link	true	/test e2e-aws-ovn-hypershift-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.