-
Notifications
You must be signed in to change notification settings - Fork 207
OCPBUGS-63311: vendor: Update openshift/api to get new ClusterVersion force Godocs #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-63311: vendor: Update openshift/api to get new ClusterVersion force Godocs #1251
Conversation
Pulling in [1]. Generated with:
$ go get github.com/openshift/api@master
$ go get github.com/openshift/client-go@master
$ go get github.com/openshift/library-go@master
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor
using:
$ go version
go version go1.24.0 linux/amd64
The client-go import addresses:
$ go mod tidy
...
go: finding module for package k8s.io/api/networking/v1alpha1
go: github.com/openshift/cluster-version-operator/pkg/cvo imports
k8s.io/client-go/kubernetes/scheme imports
k8s.io/api/networking/v1alpha1: module k8s.io/api@latest found (v0.34.1), but does not contain package k8s.io/api/networking/v1alpha1
The library-go update is just a "while I'm at it..." bump to round out
the openshift/ dependencies.
[1]: openshift/api#2539
|
@wking: This pull request references Jira Issue OCPBUGS-63311, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…gle/go-cmp/cmp Catching up with the kubernetes/kubernetes@1e9ce46f0a67 (migrate k8s.io/apimachinery/pkg/util/diff to cmp, 2019-05-14, kubernetes/kubernetes#70929) deprecation and kubernetes/kubernetes@03afe6471bdb (Add a replacement for cmp.Diff using json+go-difflib, 2025-06-16, kubernetes/kubernetes#132221) removal.
|
/verified by ci/prow/e2e-agnostic-ovn Run -> Artifacts -> ... -> inspected CRDs: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1251/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn/1983291457905102848/artifacts/e2e-agnostic-ovn/gather-extra/artifacts/inspect/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/clusterversions.config.openshift.io.yaml | yaml2json | jq -r '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.desiredUpdate.properties.force.description'
force allows an administrator to update to an image that has failed
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
operator and you have verified the authenticity of the provided
image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that comes from unknown
or potentially malicious sources. |
|
@wking: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Cool, some days ago I try to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the helpful commit descriptions.
Pulling in [1]. Generated with: $ go get github.com/openshift/api@master $ go mod tidy $ go mod vendor $ git add -A go.* vendor using: $ go version go version go1.24.0 linux/amd64 [1]: openshift/api#2560
|
I pushed cd70f16 -> 085cc7f to pick up openshift/api#2560 too. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidHurta, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by ci/prow/e2e-agnostic-ovn Run -> Artifacts -> ... -> inspected CRDs: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1251/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn/1985406692459810816/artifacts/e2e-agnostic-ovn/gather-extra/artifacts/inspect/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/clusterversions.config.openshift.io.yaml | yaml2json | jq -r '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.desiredUpdate.properties.force.description'
force allows an administrator to update to an image that has failed
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
operator and you have verified the authenticity of the provided
image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that come from unknown
or potentially malicious sources. |
|
@wking: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
I dunno if the disruption in the tech-preview job was due to the CPU-starved node or what:
But the previous run on this same commit passed, and I see no mechanism that might connect this CVO-vendor-bump with that disruption. Overriding to save money on low-signal retests: /override ci/prow/e2e-aws-ovn-techpreview |
|
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-aws-ovn-techpreview In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This run passed all its test-cases before hitting /override ci/prow/e2e-agnostic-ovn |
|
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@wking: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@wking: Jira Issue Verification Checks: Jira Issue OCPBUGS-63311 Jira Issue OCPBUGS-63311 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |

Pulling in openshift/api#2539. Generated with:
using:
The client-go import addresses:
The library-go update is just a "while I'm at it..." bump to round out the
openshift/dependencies.