Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Oct 28, 2025

Pulling in openshift/api#2539. Generated with:

$ go get github.com/openshift/api@master
$ go get github.com/openshift/client-go@master
$ go get github.com/openshift/library-go@master
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor

using:

$ go version
go version go1.24.0 linux/amd64

The client-go import addresses:

$ go mod tidy
...
go: finding module for package k8s.io/api/networking/v1alpha1
go: github.com/openshift/cluster-version-operator/pkg/cvo imports
    k8s.io/client-go/kubernetes/scheme imports
    k8s.io/api/networking/v1alpha1: module k8s.io/api@latest found (v0.34.1), but does not contain package k8s.io/api/networking/v1alpha1

The library-go update is just a "while I'm at it..." bump to round out the openshift/ dependencies.

Pulling in [1].  Generated with:

  $ go get github.com/openshift/api@master
  $ go get github.com/openshift/client-go@master
  $ go get github.com/openshift/library-go@master
  $ go mod tidy
  $ go mod vendor
  $ git add -A go.* vendor

using:

  $ go version
  go version go1.24.0 linux/amd64

The client-go import addresses:

  $ go mod tidy
  ...
  go: finding module for package k8s.io/api/networking/v1alpha1
  go: github.com/openshift/cluster-version-operator/pkg/cvo imports
    k8s.io/client-go/kubernetes/scheme imports
    k8s.io/api/networking/v1alpha1: module k8s.io/api@latest found (v0.34.1), but does not contain package k8s.io/api/networking/v1alpha1

The library-go update is just a "while I'm at it..." bump to round out
the openshift/ dependencies.

[1]: openshift/api#2539
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 28, 2025
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Jira Issue OCPBUGS-63311, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jiajliu

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Pulling in openshift/api#2539. Generated with:

$ go get github.com/openshift/api@master
$ go get github.com/openshift/client-go@master
$ go get github.com/openshift/library-go@master
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor

using:

$ go version
go version go1.24.0 linux/amd64

The client-go import addresses:

$ go mod tidy
...
go: finding module for package k8s.io/api/networking/v1alpha1
go: github.com/openshift/cluster-version-operator/pkg/cvo imports
   k8s.io/client-go/kubernetes/scheme imports
   k8s.io/api/networking/v1alpha1: module k8s.io/api@latest found (v0.34.1), but does not contain package k8s.io/api/networking/v1alpha1

The library-go update is just a "while I'm at it..." bump to round out the openshift/ dependencies.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jiajliu October 28, 2025 21:28
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2025
…gle/go-cmp/cmp

Catching up with the kubernetes/kubernetes@1e9ce46f0a67 (migrate
k8s.io/apimachinery/pkg/util/diff to cmp, 2019-05-14,
kubernetes/kubernetes#70929) deprecation and
kubernetes/kubernetes@03afe6471bdb (Add a replacement for cmp.Diff
using json+go-difflib, 2025-06-16, kubernetes/kubernetes#132221)
removal.
@wking
Copy link
Member Author

wking commented Oct 29, 2025

/verified by ci/prow/e2e-agnostic-ovn

Run -> Artifacts -> ... -> inspected CRDs:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1251/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn/1983291457905102848/artifacts/e2e-agnostic-ovn/gather-extra/artifacts/inspect/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/clusterversions.config.openshift.io.yaml | yaml2json | jq -r '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.desiredUpdate.properties.force.description'
force allows an administrator to update to an image that has failed
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
  operator and you have verified the authenticity of the provided
  image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that comes from unknown
or potentially malicious sources.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 29, 2025
@openshift-ci-robot
Copy link
Contributor

@wking: This PR has been marked as verified by ci/prow/e2e-agnostic-ovn.

In response to this:

/verified by ci/prow/e2e-agnostic-ovn

Run -> Artifacts -> ... -> inspected CRDs:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1251/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn/1983291457905102848/artifacts/e2e-agnostic-ovn/gather-extra/artifacts/inspect/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/clusterversions.config.openshift.io.yaml | yaml2json | jq -r '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.desiredUpdate.properties.force.description'
force allows an administrator to update to an image that has failed
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
 operator and you have verified the authenticity of the provided
 image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that comes from unknown
or potentially malicious sources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JianLi-RH
Copy link
Contributor

Cool, some days ago I try to add k8s.io/kubernetes/test/e2e/framework, it requires to update github.com/openshift/api

Copy link
Contributor

@DavidHurta DavidHurta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the helpful commit descriptions.

Pulling in [1].  Generated with:

  $ go get github.com/openshift/api@master
  $ go mod tidy
  $ go mod vendor
  $ git add -A go.* vendor

using:

  $ go version
  go version go1.24.0 linux/amd64

[1]: openshift/api#2560
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Nov 3, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@wking
Copy link
Member Author

wking commented Nov 3, 2025

I pushed cd70f16 -> 085cc7f to pick up openshift/api#2560 too.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Nov 3, 2025

/verified by ci/prow/e2e-agnostic-ovn

Run -> Artifacts -> ... -> inspected CRDs:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1251/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn/1985406692459810816/artifacts/e2e-agnostic-ovn/gather-extra/artifacts/inspect/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/clusterversions.config.openshift.io.yaml | yaml2json | jq -r '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.desiredUpdate.properties.force.description'
force allows an administrator to update to an image that has failed
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
  operator and you have verified the authenticity of the provided
  image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that come from unknown
or potentially malicious sources.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 3, 2025
@openshift-ci-robot
Copy link
Contributor

@wking: This PR has been marked as verified by ci/prow/e2e-agnostic-ovn.

In response to this:

/verified by ci/prow/e2e-agnostic-ovn

Run -> Artifacts -> ... -> inspected CRDs:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1251/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn/1985406692459810816/artifacts/e2e-agnostic-ovn/gather-extra/artifacts/inspect/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/clusterversions.config.openshift.io.yaml | yaml2json | jq -r '.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.desiredUpdate.properties.force.description'
force allows an administrator to update to an image that has failed
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
 operator and you have verified the authenticity of the provided
 image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that come from unknown
or potentially malicious sources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ac84d90 and 2 for PR HEAD 085cc7f in total

@wking
Copy link
Member Author

wking commented Nov 4, 2025

I dunno if the disruption in the tech-preview job was due to the CPU-starved node or what:

image

But the previous run on this same commit passed, and I see no mechanism that might connect this CVO-vendor-bump with that disruption. Overriding to save money on low-signal retests:

/override ci/prow/e2e-aws-ovn-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-aws-ovn-techpreview

In response to this:

I dunno if the disruption in the tech-preview job was due to the CPU-starved node or what:

image

But the previous run on this same commit passed, and I see no mechanism that might connect this CVO-vendor-bump with that disruption. Overriding to save money on low-signal retests:

/override ci/prow/e2e-aws-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wking
Copy link
Member Author

wking commented Nov 4, 2025

This run passed all its test-cases before hitting Process did not finish before 4h0m0s timeout during the gather-extra step. A faster build, or install, or test step, or deprovision might have each been enough to get a passing run. Don't waste CI money rerolling those dice until they line up.

/override ci/prow/e2e-agnostic-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-ovn

In response to this:

This run passed all its test-cases before hitting Process did not finish before 4h0m0s timeout during the gather-extra step. A faster build, or install, or test step, or deprovision might have each been enough to get a passing run. Don't waste CI money rerolling those dice until they line up.

/override ci/prow/e2e-agnostic-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 570c642 into openshift:main Nov 4, 2025
17 checks passed
@openshift-ci-robot
Copy link
Contributor

@wking: Jira Issue Verification Checks: Jira Issue OCPBUGS-63311
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63311 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Pulling in openshift/api#2539. Generated with:

$ go get github.com/openshift/api@master
$ go get github.com/openshift/client-go@master
$ go get github.com/openshift/library-go@master
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor

using:

$ go version
go version go1.24.0 linux/amd64

The client-go import addresses:

$ go mod tidy
...
go: finding module for package k8s.io/api/networking/v1alpha1
go: github.com/openshift/cluster-version-operator/pkg/cvo imports
   k8s.io/client-go/kubernetes/scheme imports
   k8s.io/api/networking/v1alpha1: module k8s.io/api@latest found (v0.34.1), but does not contain package k8s.io/api/networking/v1alpha1

The library-go update is just a "while I'm at it..." bump to round out the openshift/ dependencies.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wking wking deleted the ClusterVersion-force-godocs branch November 4, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants