STOR-2018: Rebase external-snapshotter to v8.1.0 for OCP 4.18 #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f40f0cc Merge pull request kubernetes-csi#256 from solumath/master cfa9210 Instruction update 379a1bb Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bb fix typo in sidecar release process 4967685 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160 Update skip list in codespell GitHub Action f5aebfc Add GitHub Actions workflows git-subtree-dir: release-tools git-subtree-split: f40f0cc
chore: update release-tools to fix spelling error
this commit adds metrics for volumegroupsnapshot Signed-off-by: yati1998 <[email protected]>
Bumps the k8s-dependencies group with 2 updates in the / directory: [github.com/kubernetes-csi/csi-lib-utils](https://github.com/kubernetes-csi/csi-lib-utils) and [k8s.io/klog/v2](https://github.com/kubernetes/klog). Updates `github.com/kubernetes-csi/csi-lib-utils` from 0.18.0 to 0.18.1 - [Release notes](https://github.com/kubernetes-csi/csi-lib-utils/releases) - [Commits](kubernetes-csi/csi-lib-utils@v0.18.0...v0.18.1) Updates `k8s.io/klog/v2` from 2.120.1 to 2.130.0 - [Release notes](https://github.com/kubernetes/klog/releases) - [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md) - [Commits](kubernetes/klog@v2.120.1...v2.130.0) --- updated-dependencies: - dependency-name: github.com/kubernetes-csi/csi-lib-utils dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/klog/v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the github-dependencies group with 9 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/prometheus/common](https://github.com/prometheus/common) | `0.53.0` | `0.54.0` | | [github.com/spf13/cobra](https://github.com/spf13/cobra) | `1.8.0` | `1.8.1` | | google.golang.org/protobuf | `1.34.1` | `1.34.2` | | [github.com/emicklei/go-restful/v3](https://github.com/emicklei/go-restful) | `3.12.0` | `3.12.1` | | [github.com/go-logr/logr](https://github.com/go-logr/logr) | `1.4.1` | `1.4.2` | | [github.com/prometheus/procfs](https://github.com/prometheus/procfs) | `0.15.0` | `0.15.1` | | [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) | `0.51.0` | `0.52.0` | | [golang.org/x/net](https://github.com/golang/net) | `0.25.0` | `0.26.0` | | [golang.org/x/oauth2](https://github.com/golang/oauth2) | `0.20.0` | `0.21.0` | Updates `github.com/prometheus/common` from 0.53.0 to 0.54.0 - [Release notes](https://github.com/prometheus/common/releases) - [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md) - [Commits](prometheus/common@v0.53.0...v0.54.0) Updates `github.com/spf13/cobra` from 1.8.0 to 1.8.1 - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.8.0...v1.8.1) Updates `google.golang.org/protobuf` from 1.34.1 to 1.34.2 Updates `github.com/emicklei/go-restful/v3` from 3.12.0 to 3.12.1 - [Release notes](https://github.com/emicklei/go-restful/releases) - [Changelog](https://github.com/emicklei/go-restful/blob/v3/CHANGES.md) - [Commits](emicklei/go-restful@v3.12.0...v3.12.1) Updates `github.com/go-logr/logr` from 1.4.1 to 1.4.2 - [Release notes](https://github.com/go-logr/logr/releases) - [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md) - [Commits](go-logr/logr@v1.4.1...v1.4.2) Updates `github.com/prometheus/procfs` from 0.15.0 to 0.15.1 - [Release notes](https://github.com/prometheus/procfs/releases) - [Commits](prometheus/procfs@v0.15.0...v0.15.1) Updates `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` from 0.51.0 to 0.52.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.51.0...zpages/v0.52.0) Updates `go.opentelemetry.io/otel` from 1.26.0 to 1.27.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.26.0...v1.27.0) Updates `go.opentelemetry.io/otel/metric` from 1.26.0 to 1.27.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.26.0...v1.27.0) Updates `go.opentelemetry.io/otel/trace` from 1.26.0 to 1.27.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.26.0...v1.27.0) Updates `golang.org/x/net` from 0.25.0 to 0.26.0 - [Commits](golang/net@v0.25.0...v0.26.0) Updates `golang.org/x/oauth2` from 0.20.0 to 0.21.0 - [Commits](golang/oauth2@v0.20.0...v0.21.0) Updates `golang.org/x/sys` from 0.20.0 to 0.21.0 - [Commits](golang/sys@v0.20.0...v0.21.0) Updates `golang.org/x/term` from 0.20.0 to 0.21.0 - [Commits](golang/term@v0.20.0...v0.21.0) Updates `golang.org/x/text` from 0.15.0 to 0.16.0 - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.15.0...v0.16.0) Updates `google.golang.org/genproto/googleapis/rpc` from 0.0.0-20240318140521-94a12d6c2237 to 0.0.0-20240520151616-dc85e6b867a5 - [Commits](https://github.com/googleapis/go-genproto/commits) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: github.com/emicklei/go-restful/v3 dependency-type: indirect update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: github.com/go-logr/logr dependency-type: indirect update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: github.com/prometheus/procfs dependency-type: indirect update-type: version-update:semver-patch dependency-group: github-dependencies - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: go.opentelemetry.io/otel dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: go.opentelemetry.io/otel/metric dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: go.opentelemetry.io/otel/trace dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/net dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/oauth2 dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/sys dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/term dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/text dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: google.golang.org/genproto/googleapis/rpc dependency-type: indirect update-type: version-update:semver-patch dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
Add group snapshot controller metrics
The controller is using an informer to get VolumeGroupSnapshotClasses and VolumeSnapshotClasses. Unfortunately, objects returned by that will not have the API Kind info set. This prevented the IsDefaultAnnotation function from working correctly. This patch avoid relying on the object Kind to know whether a VolumeGroupSnapshotClass or a VolumeSnapshotClass is set as default. See: kubernetes/client-go#308 Signed-off-by: Leonardo Cecchi <[email protected]>
…-mix Avoid group snapshot provisioning with mismatching CSI Drivers
Correctly detect newly created Volume[Group]SnapshotClasses
…/go_modules/k8s-dependencies-d82f4e7c70 Bump the k8s-dependencies group across 1 directory with 2 updates
…/go_modules/github-dependencies-8264378a33 Bump the github-dependencies group across 1 directory with 16 updates
Bumps the k8s-dependencies group with 1 update: [k8s.io/klog/v2](https://github.com/kubernetes/klog). Updates `k8s.io/klog/v2` from 2.130.0 to 2.130.1 - [Release notes](https://github.com/kubernetes/klog/releases) - [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md) - [Commits](kubernetes/klog@v2.130.0...v2.130.1) --- updated-dependencies: - dependency-name: k8s.io/klog/v2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…/go_modules/k8s-dependencies-f351cbf957 Bump k8s.io/klog/v2 from 2.130.0 to 2.130.1 in the k8s-dependencies group
Signed-off-by: Abhishek Jain <[email protected]>
update Kubernetes to 1.31.0-rc.0
Update controller deployment to latest version
The previous `removePVCFinalizer` function was using the PVC stored in the informer which, in cases where the PVC had been modified since, lead to conflict errors when trying to remove the PVC finalizer through an update. Now the `removePVCFinalizer` function uses the `RetryOnConflict` helper to make sure the update goes through.
988496a1f Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c698 chore: bump to Go 1.22.5 69bd71e8a chore: add CSI_PROW_SIDECAR_E2E_PATH git-subtree-dir: release-tools git-subtree-split: 988496a1fc3849ed793e03012fdd56813d13d46c
…ease-tools cleanup: Update csi release tools
Bump Kubernetes to v1.31.0
Bumps the github-dependencies group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) | `1.19.1` | `1.20.0` | | [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) | `0.52.0` | `0.53.0` | | [golang.org/x/net](https://github.com/golang/net) | `0.26.0` | `0.28.0` | | [golang.org/x/oauth2](https://github.com/golang/oauth2) | `0.21.0` | `0.22.0` | | [golang.org/x/time](https://github.com/golang/time) | `0.5.0` | `0.6.0` | Updates `github.com/prometheus/client_golang` from 1.19.1 to 1.20.0 - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.0/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.19.1...v1.20.0) Updates `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` from 0.52.0 to 0.53.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.52.0...zpages/v0.53.0) Updates `golang.org/x/net` from 0.26.0 to 0.28.0 - [Commits](golang/net@v0.26.0...v0.28.0) Updates `golang.org/x/oauth2` from 0.21.0 to 0.22.0 - [Commits](golang/oauth2@v0.21.0...v0.22.0) Updates `golang.org/x/sys` from 0.21.0 to 0.23.0 - [Commits](golang/sys@v0.21.0...v0.23.0) Updates `golang.org/x/term` from 0.21.0 to 0.23.0 - [Commits](golang/term@v0.21.0...v0.23.0) Updates `golang.org/x/text` from 0.16.0 to 0.17.0 - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.16.0...v0.17.0) Updates `golang.org/x/time` from 0.5.0 to 0.6.0 - [Commits](golang/time@v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/net dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/oauth2 dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/sys dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/term dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/text dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies - dependency-name: golang.org/x/time dependency-type: indirect update-type: version-update:semver-minor dependency-group: github-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…/go_modules/github-dependencies-8fd52b1f47 Bump the github-dependencies group across 1 directory with 8 updates
openshift-ci-robot
added
the
jira/valid-reference
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
and remove .github
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
openshift-ci
bot
added
px-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, rhrmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@rhrmo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The CI result looks good. |
openshift-ci
bot
added
the
qe-approved
|
[ART PR BUILD NOTIFIER] Distgit: ose-csi-snapshot-controller |
|
[ART PR BUILD NOTIFIER] Distgit: csi-snapshot-validation-webhook |
|
[ART PR BUILD NOTIFIER] Distgit: ose-csi-external-snapshotter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff to upstream 8.1.0:
kubernetes-csi/external-snapshotter@v8.1.0...rhrmo:rebase-8.1.0
Notable changes between 8.0.1 (OCP 4.17) and 8.1.0 (OCP 4.18):
Full changelogs:
https://github.com/kubernetes-csi/external-snapshotter/blob/v8.1.0/CHANGELOG/CHANGELOG-8.1.md
@openshift/storage