Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from github.com/imdario/mergo to dario.cat/mergo #4734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Dec 5, 2024

- What I did

Update the dependency and its path.

- How to verify it

Should not break the CI.

- Description for the changelog

None

@saschagrunert
Copy link
Member Author

/retest

2 similar comments
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

@rphillips @haircommander @QiWang19 PTAL

@haircommander
Copy link
Member

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@djoshy
Copy link
Contributor

djoshy commented Dec 13, 2024

/test all

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@saschagrunert
Copy link
Member Author

Rebased this one.

Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

New changes are detected. LGTM label has been removed.

@saschagrunert
Copy link
Member Author

/retest

1 similar comment
@saschagrunert
Copy link
Member Author

/retest

@QiWang19
Copy link
Member

/retest-required

@saschagrunert
Copy link
Member Author

/retest-required

I doubt right now that the failing test is related to the change of this PR. 🤔

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 20fc4c7 link false /test okd-scos-e2e-aws-ovn
ci/prow/verify 20fc4c7 link true /test verify
ci/prow/unit 20fc4c7 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants