-
Notifications
You must be signed in to change notification settings - Fork 448
OCPBUGS-61384: Fix scheduling for keepalived #5302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@mkowalski: This pull request references Jira Issue OCPBUGS-61384, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@mkowalski: This pull request references Jira Issue OCPBUGS-61384, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@mkowalski: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm If it helps avoid keepalived getting blamed for every performance issue ever, I'm all for it. :-) |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cybertron, mkowalski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @rbbratta for verified label? I tested it on my dev-scripts setup and worked but in principle I should not be testing my own changes |
- What I did
Modified scheduling configuration of keepalived. It is supposed to give more resources/priority so that keepalived is less prone to miss its healtchecks in a scenario where it gets less CPU than it needs.
- How to verify it
Deploy a cluster using metal platform. Confirm installation succeeds. Use dev-scripts or any other test environment of your choice.
- Description for the changelog
Scheduling configuration for keepalived process has been changed. As a result, the process should be more robust and unnecessary VIP failovers should be happening less often.
Fixes: OCPBUGS-61384