-
Notifications
You must be signed in to change notification settings - Fork 448
MCO-1685: Add mco-sanitize utility main logic #5303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCO-1685: Add mco-sanitize utility main logic #5303
Conversation
34153ab
to
e348dff
Compare
@pablintino: This pull request references MCO-1685 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The changes look fair & I see that the unit tests for the new functionality are passing.
/verified bypass |
@pablintino: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
e348dff
to
52e59dd
Compare
@pablintino: This pull request references MCO-1685 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5e88be9
to
018d259
Compare
/retest-required |
Pre-merge tested Steps to use the tool
WITH REDACTED
WITHOUT REDACTED
/qe-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for adding a readme!
/verified bypass |
ah, looks like we have a conflict. Can override the failing tests once that's been resolved. |
This changes adds encryption to the output of the sanitizer. For now, till the mco-sanitize tool is properly validated in CI, encryption cannot be disabled.
018d259
to
2e453ab
Compare
@yuqi-zhang how inconvenient :(. Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tagged was removed with a rebase, so I'm adding it back.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@pablintino I think your |
/verified by QE at #5303 (comment) |
@pablintino: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
/retest-required |
/retest |
/override ci/prow/e2e-aws-ovn-upgrade |
@pablintino: Overrode contexts on behalf of pablintino: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/e2e-aws-ovn-upgrade overriding again as another PR merged, causing reruns |
@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
b6edf8e
into
openshift:main
@pablintino: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This change adds the missing pieces of the mco-sanitizer to finish its implementation, including encryption and a brief README.
./mco-sanitize --input /path/to/must-gather-directory
. Check if the CRs of the MCO directories are properly sanitized and that are safe to push../mco-sanitize --input /path/to/must-gather-directory --output encrypted.tar.gz
. Check that the output file is encrypted.Implements the main functionality of the mco-sanitizer.