Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-4277: Small fixes including update for beta mirror changes #4220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sjug
Copy link
Contributor

@sjug sjug commented Nov 25, 2024

  • Update RHEL iso to 9.4
  • Create longer lived metrics token
  • Modify beta repo templates
  • Improve start timing for CSI pods
  • Remove comments & rename step
  • Update cadvisor
  • Add metrics_host to crio metrics config

- Update RHEL iso to 9.4
- Create longer lived metrics token
- Modify beta repo templates
- Improve start timing for CSI pods
- Remove comments & rename step
- Update cadvisor
- Add metrics_host to crio metrics config
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024

@sjug: This pull request references USHIFT-4277 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

  • Update RHEL iso to 9.4
  • Create longer lived metrics token
  • Modify beta repo templates
  • Improve start timing for CSI pods
  • Remove comments & rename step
  • Update cadvisor
  • Add metrics_host to crio metrics config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from agullon and jerpeter1 November 25, 2024 14:56
Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sjug
Once this PR has been reviewed and has the lgtm label, please assign agullon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

@sjug: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify b84e130 link true /test verify
ci/prow/security b84e130 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -1,10 +1,12 @@
---
# manage-repos default vars

microshift_version: 4.14.0-rc.4
ocp_repo_name: microshift-{{ ocp_version }}-for-rhel-{{ ansible_distribution_major_version }}-mirrorbeta-{{ ansible_architecture }}-rpms
microshift_version: 4.17.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 4.18 instead? Content for 4.17 is already in the rhocp repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants