Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-44695: Port mirror registry to use Quay #4369

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Dec 30, 2024

First part of the implementation is to reach feature parity with the current distribution registry.

Performance comparison

Performance comparison of the Distribution and Quay registries was performed on a c6g.metal host
Conclusion: TBD

  • Looks like Quay bootstrap is ~1m slower than the Distribution one.

Bootstrap

./test/bin/manage_composer_config.sh cleanup ; sudo rm -rf ./_output/test-images/mirror-registry/
time ./test/bin/mirror_registry.sh

Distribution: ~1m
Quay: ~2m

Builds

time bash -c '\
  ./test/bin/build_bootc_images.sh -l ./test/image-blueprints-bootc/layer1-base/ && \
  ./test/bin/build_bootc_images.sh -l ./test/image-blueprints-bootc/layer2-source'

Distribution: ~16m
Quay: ~17m

Bootstrap & Builds

./test/bin/manage_composer_config.sh cleanup ; sudo rm -rf ./_output/test-images/mirror-registry/
time bash -c '\
  ./test/bin/build_bootc_images.sh -l ./test/image-blueprints-bootc/layer1-base/ && \
  ./test/bin/build_bootc_images.sh -l ./test/image-blueprints-bootc/layer2-source'

Distribution: TBD
Quay: TBD

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2024
Copy link
Contributor

openshift-ci bot commented Dec 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Dec 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 30, 2024
@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-44926, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash force-pushed the quay_mirror_registry branch from cf6ff2a to ce49ff9 Compare December 30, 2024 17:03
@ggiguash
Copy link
Contributor Author

/test ?

Copy link
Contributor

openshift-ci bot commented Dec 30, 2024

@ggiguash: The following commands are available to trigger required jobs:

/test e2e-aws-footprint-and-performance
/test e2e-aws-tests
/test e2e-aws-tests-arm
/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm
/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm
/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm
/test e2e-aws-tests-periodic
/test e2e-aws-tests-periodic-arm
/test images
/test ocp-full-conformance-rhel-eus
/test ocp-full-conformance-serial-rhel-eus
/test test-rpm
/test test-unit
/test verify

The following commands are available to trigger optional jobs:

/test security
/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests
pull-ci-openshift-microshift-main-e2e-aws-tests-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-periodic
pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm
pull-ci-openshift-microshift-main-images
pull-ci-openshift-microshift-main-security
pull-ci-openshift-microshift-main-test-unit
pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc
/test e2e-aws-tests

@ggiguash ggiguash changed the title OCPBUGS-44926: Port mirror registry to use Quay OCPBUGS-44695: Port mirror registry to use Quay Dec 31, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 31, 2024
@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-44695, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jogeo December 31, 2024 07:00
@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc
/test e2e-aws-tests

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm

@ggiguash ggiguash force-pushed the quay_mirror_registry branch from 30ed483 to 4627a2a Compare January 1, 2025 08:57
@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-44695, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

In response to this:

First part of the implementation is to reach feature parity with the current distribution registry.

Performance comparison of the Distribution and Quay registries performed on a c6g.metal host, using the following commands.

./test/bin/manage_composer_config.sh cleanup ; sudo rm -rf ./_output/test-images/mirror-registry/
time ./test/bin/mirror_registry.sh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash force-pushed the quay_mirror_registry branch from 31ba964 to 1f8ef94 Compare January 1, 2025 12:15
@ggiguash
Copy link
Contributor Author

ggiguash commented Jan 3, 2025

/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm

1 similar comment
@ggiguash
Copy link
Contributor Author

ggiguash commented Jan 3, 2025

/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm

@ggiguash ggiguash marked this pull request as ready for review January 3, 2025 15:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2025
@openshift-ci openshift-ci bot requested review from copejon and pacevedom January 3, 2025 15:42
Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

@ggiguash: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc-periodic ca6ef58 link true /test e2e-aws-tests-bootc-periodic
ci/prow/verify ca6ef58 link true /test verify
ci/prow/e2e-aws-tests-bootc ca6ef58 link true /test e2e-aws-tests-bootc
ci/prow/e2e-aws-tests-bootc-periodic-arm ca6ef58 link true /test e2e-aws-tests-bootc-periodic-arm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants