-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add golangci-lint #1254
feat: Add golangci-lint #1254
Conversation
Signed-off-by: Mateus Oliveira <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mateusoliveira43 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mateus Oliveira <[email protected]>
/hold |
let's have a little demo / socialization of what the lint rules are first. |
@mateusoliveira43: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
closing in favor of #1337 |
Add more linting checks to project with
golangci-lint
..golangci.yaml
is similar to the one proposed at vmware-tanzu/velero#7194Test
Run
golangci-lint
with newmake lint
andmake lint-fix
commands.TODO
All go files changes where done through
make lint-fix
command. There are still a lot of issues to be resolved in the code.golangci-lint
comes with newer versions of kubebuilder, if #1250 is accepted, merge this one first and addgolangci-lint
to operator-sdk version update docs.