[oadp-1.4] OADP-4213: Backport VM E2E tests to OADP-1.4.

[mrnold]

Pull the virtual machine tests into the 1.4 branch. I tried cherry-picking the merges from the original work, but there were enough conflicts and intermediate throwaway changes that it was actually smaller to flatten them all into one. (See this temporary work branch.

Why the changes were made

Addresses https://issues.redhat.com/browse/OADP-4213.

How to test the changes made

make TEST_VIRT=true test-e2e

[openshift-ci-robot]

@mrnold: This pull request references OADP-4213 which is a valid jira issue.

In response to this:

Pull the virtual machine tests into the 1.4 branch. I tried cherry-picking the merges from the original work, but there were enough conflicts and intermediate throwaway changes that it was actually smaller to flatten them all into one. (See this temporary work branch.

Why the changes were made

Addresses https://issues.redhat.com/browse/OADP-4213.

How to test the changes made

make TEST_VIRT=true test-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mateusoliveira43]

also need to add virt test to prow in 1.4 branch?

[mrnold]

also need to add virt test to prow in 1.4 branch?

Yes, although I am not sure which one should go first. I guess oadp-operator CI will be broken for a short time either way?

[mrnold]

/test 4.13-e2e-test-aws

[mateusoliveira43]

I tried to pin down all virt commits
e379366
fc6afbf
3f5ae3b
da83a07
20ee343
0cbd8db
de659f2
bf64895
1be7785
424a33a
0a83396

and checked differences between files (for example git diff master mrnold/oadp-1.4-backport-vm-ci -- tests/e2e/virt_backup_restore_suite_test.go). Some files are not equal, but logic seems the same

If we want to exactly copy files from master, we could run something like git restore -s master tests/ from this branch

[mrnold]

I tried to pin down all virt commits e379366 fc6afbf 3f5ae3b da83a07 20ee343 0cbd8db de659f2 bf64895 1be7785 424a33a 0a83396

and checked differences between files (for example git diff master mrnold/oadp-1.4-backport-vm-ci -- tests/e2e/virt_backup_restore_suite_test.go). Some files are not equal, but logic seems the same

If we want to exactly copy files from master, we could run something like git restore -s master tests/ from this branch

There were a few pull requests that were merged in between the commits in that list, like #1253, #1337, and #1287. So copying files straight from master probably won't work unless we want to backport every E2E change.

[mateusoliveira43]

/retest

[mateusoliveira43]

/label approved

[openshift-ci]

@mateusoliveira43: Can not set label approved: Must be member in one of these teams: [openshift-release-oversight openshift-staff-engineers]

In response to this:

/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mateusoliveira43]

manually added approved label for PR to appear in review board (it was not automatically added because OWNERS file in oadp-1.4 branch is outdated?)

[weshayutin]

https://termbin.com/dt78

Ran 3 of 35 Specs in 1709.082 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 32 Skipped
PASS

Ginkgo ran 1 suite in 28m34.212272754s
Test Suite Passed
whayutin@thinkdoe:~/OPENSHIFT/git/OADP/oadp-operator$ oc version
Client Version: 4.12.0-202301042354.p0.g854f807.assembly.stream-854f807
Kustomize Version: v4.5.7
Server Version: 4.16.0-rc.3
Kubernetes Version: v1.29.5+87992f4

[weshayutin]

/LGTM

[shubham-pampattiwar]

Tests ran successfully for me as well on OCP 4.16-rc-2:

Ran 3 of 35 Specs in 2014.829 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 32 Skipped
You're using deprecated Ginkgo functionality:
=============================================
  --ginkgo.slow-spec-threshold is deprecated --slow-spec-threshold has been deprecated and will be removed in a future version of Ginkgo.  This feature has proved to be more noisy than useful.  You can use --poll-progress-after, instead, to get more actionable feedback about potentially slow specs and understand where they might be getting stuck.

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=2.14.0

PASS

Ginkgo ran 1 suite in 34m13.247793985s
Test Suite Passed
shubham@fedora ~/oadp-operator -  (matthew-virt-pr) $ oc version
Client Version: 4.14.7
Kustomize Version: v5.0.1
Server Version: 4.16.0-rc.2
Kubernetes Version: v1.29.4+acf69ee
shubham@fedora ~/oadp-operator -  (matthew-virt-pr) $ 

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrnold, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@mrnold: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.