Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-45011#rearrange step order #86647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-45011#rearrange step order #86647

wants to merge 1 commit into from

Conversation

brendan-daly-red-hat
Copy link
Contributor

@brendan-daly-red-hat brendan-daly-red-hat commented Jan 2, 2025 •
edited
Loading

Versions:
4.17+

Issue:
https://issues.redhat.com/browse/OCPBUGS-45011

Link to docs preview:
Restricting the API server to private

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 2, 2025
@ocpdocs-previewbot
Copy link

🤖 Thu Jan 02 16:03:49 - Prow CI generated the docs preview:

https://86647--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.html
https://86647--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.html
https://86647--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/configuring-private-cluster.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jan 2, 2025
View reviewed changes
modules/private-clusters-setting-api-private.adoc
. In the web portal or console for your cloud provider, take the following actions:

.. Locate and delete the appropriate load balancer component:
ifndef::cpmso-using-azure[]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDoc.ValidConditions: File contains unbalanced if statements. Review the file to ensure it contains matching opening and closing if statements.

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jan 2, 2025
View reviewed changes
modules/private-clusters-setting-api-private.adoc
endif::cpmso-using-aws[]

.. Delete the
ifdef::cpmso-using-aws[`api.$clustername.$yourdomain`]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDoc.ValidConditions: File contains unbalanced if statements. Review the file to ensure it contains matching opening and closing if statements.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 2, 2025

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@brendan-daly-red-hat
Copy link
Contributor Author

@gpei, PTAL at the draft update.

@gpei
Copy link

gpei commented Jan 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees

@gpei gpei

Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brendan-daly-red-hat @ocpdocs-previewbot @gpei @ocpdocs-vale-bot