Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enterprise-4.16] OSDOCS#50922: Improving docs for setting up memory overcommit #86671

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

jherrman
Copy link
Contributor

@jherrman jherrman commented Jan 3, 2025

Cherrypicked from b4a87e5 xref: #85991

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 3, 2025
@jherrman jherrman changed the title Improving docs for setting up memory overcommit OSDOCS#50922: Improving docs for setting up memory overcommit Jan 3, 2025
@ocpdocs-previewbot
Copy link

Copy link

openshift-ci bot commented Jan 3, 2025

@jherrman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jherrman
Copy link
Contributor Author

jherrman commented Jan 3, 2025

Since reviews of the proposed changes have already been done in #85991 and https://issues.redhat.com/browse/CNV-50922 , I'll be moving this straight into merge review.

@jherrman
Copy link
Contributor Author

jherrman commented Jan 3, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 3, 2025
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 3, 2025
@jeana-redhat jeana-redhat changed the title OSDOCS#50922: Improving docs for setting up memory overcommit [enterprise-4.16] OSDOCS#50922: Improving docs for setting up memory overcommit Jan 3, 2025
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR title and comment 0 according to our process doc (this helps consistent tracking 🙂)

I left the original comment zero in the source in case it's needed but hid it from display.

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 3, 2025
@jeana-redhat jeana-redhat merged commit 4fe355a into openshift:enterprise-4.16 Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants