Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enterprise-4.17] Incorrect configuration of namespace object for the Red Hat OpenShift Logging Operator #86694

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #86672

/assign xenolinux

… Logging Operator

- Incorrect indentation mentioned in the step5 "namespace object for the Red Hat OpenShift Logging Operator"  [2] of "Installing Logging and the Loki Operator using the CLI" documentation  [1].

- Here are the documentation links:
 [1] https://docs.openshift.com/container-platform/4.14/observability/logging/log_storage/installing-log-storage.html#logging-loki-cli-install_installing-log-storage

[2] https://docs.openshift.com/container-platform/4.14/observability/logging/log_storage/installing-log-storage.html#logging-loki-cli-install_installing-log-storage:~:text=Create%20a%20namespace%20object%20for%20the%20Red%20Hat%20OpenShift%20Logging%20Operator%3A

- Here is the Step5:
~~~
apiVersion: v1
kind: Namespace
metadata:
  name: openshift-logging
annotations:                        <<== Incorrect Indentation
    openshift.io/node-selector: ""
labels:                             <<== Incorrect Indentation
    openshift.io/cluster-logging: "true"
    openshift.io/cluster-monitoring: "true"
~~~
- `annotations`, and `labels` should be indented under the `metadata` field and inline with `name`.
- Here is the correct configuration of Step5:
~~~

~~~
- We need to perform this change under our standard documentation.
- Please refer Step1 from the same documentation for reference.
--------
1. Create a Namespace object for Loki Operator:
~~~

~~~
--------------
Copy link

openshift-ci bot commented Jan 6, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux xenolinux merged commit 76441f5 into openshift:enterprise-4.17 Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants