Skip to content

Conversation

@ngopalak-redhat
Copy link
Contributor

@ngopalak-redhat ngopalak-redhat commented Nov 7, 2025

Added test for OCPNODE-3719
Adds a test to make sure that node sizing enabled is set correctly on the node.

The test is currently failing as the dev PRs are not merged. But the code can be reviewed:

I1107 13:48:39.570486 485199 client.go:465] Project "e2e-test-node-sizing-dkmgw" has been fully provisioned.
  STEP: Getting a worker node to test @ 11/07/25 13:48:39.57
I1107 13:48:39.583496 485199 node_sizing.go:36] Testing on node: ci-op-lw9pip4i-4cd5c-dskbw-worker-0-266px
  STEP: Setting privileged pod security labels on namespace @ 11/07/25 13:48:39.583
namespace/e2e-test-node-sizing-dkmgw labeled
  STEP: Creating a privileged pod with /etc mounted @ 11/07/25 13:48:39.749
  STEP: Waiting for pod to be running @ 11/07/25 13:48:39.804
  STEP: Verifying /etc/node-sizing-enabled.env file exists @ 11/07/25 13:48:44.825
  STEP: Reading /etc/node-sizing-enabled.env file contents @ 11/07/25 13:48:45.071
I1107 13:48:45.376484 485199 node_sizing.go:118] Contents of /etc/node-sizing-enabled.env:
NODE_SIZING_ENABLED=false
SYSTEM_RESERVED_MEMORY=1Gi
SYSTEM_RESERVED_CPU=500m
SYSTEM_RESERVED_ES=1Gi
  STEP: Verifying NODE_SIZING_ENABLED=true is set in the file @ 11/07/25 13:48:45.376
  STEP: Cleaning up test pod @ 11/07/25 13:48:45.376
  [FAILED] in [It] - github.com/openshift/origin/test/extended/node/node_sizing.go:121 @ 11/07/25 13:48:45.401

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ngopalak-redhat
Copy link
Contributor Author

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ngopalak-redhat
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ngopalak-redhat
Copy link
Contributor Author

/hold wait for the dev prs to merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2025
@ngopalak-redhat ngopalak-redhat changed the title Add auto-sizing-reversed test to origin OCPNODE-3719: Add auto-sizing-reversed test to origin Nov 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2025

@ngopalak-redhat: This pull request references OCPNODE-3719 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Added test for OCPNODE-3719
Adds a test to make sure that node sizing enabled is set correctly on the node.

The test is currently failing as the dev PRs are not merged. But the code can be reviewed:

I1107 13:48:39.570486 485199 client.go:465] Project "e2e-test-node-sizing-dkmgw" has been fully provisioned.
 STEP: Getting a worker node to test @ 11/07/25 13:48:39.57
I1107 13:48:39.583496 485199 node_sizing.go:36] Testing on node: ci-op-lw9pip4i-4cd5c-dskbw-worker-0-266px
 STEP: Setting privileged pod security labels on namespace @ 11/07/25 13:48:39.583
namespace/e2e-test-node-sizing-dkmgw labeled
 STEP: Creating a privileged pod with /etc mounted @ 11/07/25 13:48:39.749
 STEP: Waiting for pod to be running @ 11/07/25 13:48:39.804
 STEP: Verifying /etc/node-sizing-enabled.env file exists @ 11/07/25 13:48:44.825
 STEP: Reading /etc/node-sizing-enabled.env file contents @ 11/07/25 13:48:45.071
I1107 13:48:45.376484 485199 node_sizing.go:118] Contents of /etc/node-sizing-enabled.env:
NODE_SIZING_ENABLED=false
SYSTEM_RESERVED_MEMORY=1Gi
SYSTEM_RESERVED_CPU=500m
SYSTEM_RESERVED_ES=1Gi
 STEP: Verifying NODE_SIZING_ENABLED=true is set in the file @ 11/07/25 13:48:45.376
 STEP: Cleaning up test pod @ 11/07/25 13:48:45.376
 [FAILED] in [It] - github.com/openshift/origin/test/extended/node/node_sizing.go:121 @ 11/07/25 13:48:45.401

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2025
@ngopalak-redhat
Copy link
Contributor Author

cc: @asahay19

@ngopalak-redhat ngopalak-redhat marked this pull request as ready for review November 7, 2025 14:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2025
@openshift-ci openshift-ci bot requested review from deads2k and sjenning November 7, 2025 14:35
@ngopalak-redhat
Copy link
Contributor Author

@haircommander @sairameshv Please review the test. I have kept the PR on hold so that the dev PRs can merge.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@ngopalak-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn 9083a46 link true /test e2e-vsphere-ovn
ci/prow/e2e-gcp-ovn-upgrade 9083a46 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-vsphere-ovn-upi 9083a46 link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-gcp-csi 9083a46 link true /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-fips 9083a46 link true /test e2e-aws-ovn-fips
ci/prow/e2e-gcp-ovn 9083a46 link true /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 9083a46 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt
Copy link

openshift-trt bot commented Nov 18, 2025

Job Failure Risk Analysis for sha: 9083a46

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-vsphere-ovn High
[Monitor:known-image-checker][sig-arch] Only known images used by tests
This test has passed 100.00% of 18 runs on release 4.21 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 Owner:eng Platform:vsphere Procedure:none SecurityMode:default Topology:ha Upgrade:none] in the last week.

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 9083a46

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-fips High - "[sig-node] Node sizing should have NODE_SIZING_ENABLED=true in /etc/node-sizing-enabled.env [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 High - "[sig-node] Node sizing should have NODE_SIZING_ENABLED=true in /etc/node-sizing-enabled.env [Suite:openshift/conformance/parallel]" is a new test that was not present in all runs against the current commit, and also failed 1 time(s).
pull-ci-openshift-origin-main-e2e-vsphere-ovn High - "[sig-node] Node sizing should have NODE_SIZING_ENABLED=true in /etc/node-sizing-enabled.env [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi High - "[sig-node] Node sizing should have NODE_SIZING_ENABLED=true in /etc/node-sizing-enabled.env [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit

New tests seen in this PR at sha: 9083a46

  • "[sig-node] Node sizing should have NODE_SIZING_ENABLED=true in /etc/node-sizing-enabled.env [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 1, Fail: 4, Flake: 0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants